On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 17 Sep 2024 13:48:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Tue, 17 Sep 2024 13:00:09 GMT, Kevin Rushforth wrote:
>> It is ok to use instance variable for SubresourceIntegrityTest. there is no
>> issue.
>
> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
> Please don't mark this as "resolved" until it is, and @arapte is sa
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove instance variables in parametrized test
-
On Tue, 17 Sep 2024 13:45:03 GMT, Jay Bhaskar wrote:
>> @jaybhaskar Yes, there is an issue as the above comment from @arapte shows.
>> Please don't mark this as "resolved" until it is, and @arapte is satisfied.
>
> Thanks , I have modified and push according
I found issue , and done changes acc
On Tue, 17 Sep 2024 12:13:19 GMT, Jay Bhaskar wrote:
>> I also think the test needs to be modified as suggested by @Maran23 and
>> @andy-goryachev-oracle .
>> With the changes in this PR the member variables are never assigned with
>> value.
>> I verified the values of the two member variables
On Tue, 17 Sep 2024 11:22:56 GMT, Ambarish Rapte wrote:
>> I think you need to do the same as done by @andy-goryachev-oracle in his
>> JUnit5 replacement PR:
>>
>> public void setup(String hashValue, String expected) throws Exception {
>> htmlFile = new File("subresource-integrity-t
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Cleaning according review comments
-
Change
On Mon, 16 Sep 2024 12:01:41 GMT, Marius Hanl wrote:
>> In this case, keeping the values as instance variables is more reliable.
>> Since all the tests pass when hashValue and expected are instance variables
>> and some of them fail when I adding parameter to
>> testScriptTagWithCorrectHashV
On Mon, 16 Sep 2024 23:03:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 23:03:50 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Mon, 16 Sep 2024 17:09:14 GMT, Kevin Rushforth wrote:
>> already did like Copyright (c) 2011, 2022,
>
> No, what happened is that the _way_ you reverted your copyright change caused
> a change that you had earlier merged in from master to be lost. So you have
> effectively undone a change th
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Year change should be reverted as main
-
Ch
On Mon, 16 Sep 2024 16:29:25 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/HistoryTest.java line
>> 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>
>> Year change should be reverted.
>
> already
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
remove old juini4 imports
-
Changes:
- al
On Mon, 16 Sep 2024 16:19:19 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into testsprint
>> - revert copyright date
>> - Revert "copyrig
On Mon, 16 Sep 2024 15:49:39 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains seven commits:
>>
>> - Merge branch 'master' into testsprint
>> - revert copyright date
>> - Revert "copyrig
On Mon, 16 Sep 2024 15:35:19 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request with a new target base due to a
> merge or a rebase. The pull requ
On Mon, 16 Sep 2024 15:32:15 GMT, Jay Bhaskar wrote:
>> @Maran23 is right. In the absence of support for parameterized class-level
>> tests the easiest solution (I think) is to parameterize every `@Test`, which
>> means:
>> - add parameters to each method, replace `@Test` with `@ParameterizedT
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains seven commits:
- Merge branch 'master' into
On Mon, 16 Sep 2024 14:54:43 GMT, Andy Goryachev wrote:
>> I think you need to do the same as done by @andy-goryachev-oracle in his
>> JUnit5 replacement PR:
>>
>> public void setup(String hashValue, String expected) throws Exception {
>> htmlFile = new File("subresource-integrity-t
On Mon, 16 Sep 2024 15:10:48 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with two additional
> commits since the last revisio
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with two additional
commits since the last revision:
- revert copyright date
- Revert "copyright year updated
On Mon, 16 Sep 2024 12:54:45 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> converting newly added tests to JUNIT5
>
> modules/javafx.web/src/test/java/test/com/sun/webkit/SharedBufferTest.java
On Mon, 16 Sep 2024 12:01:41 GMT, Marius Hanl wrote:
>> In this case, keeping the values as instance variables is more reliable.
>> Since all the tests pass when hashValue and expected are instance variables
>> and some of them fail when I adding parameter to
>> testScriptTagWithCorrectHashV
On Mon, 16 Sep 2024 01:23:52 GMT, Jay Bhaskar wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
>> are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision
On Sun, 15 Sep 2024 23:53:20 GMT, Jay Bhaskar wrote:
>> modules/javafx.web/src/test/java/test/javafx/scene/web/SubresourceIntegrityTest.java
>> line 99:
>>
>>> 97: @ParameterizedTest
>>> 98: @MethodSource("dataProvider")
>>> 99: public void testScriptTagWithCorrectHashValue() {
>>
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
converting newly added tests to JUNIT5
-
Ch
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains three commits:
- resolve conflict
- copyri
On Sun, 15 Sep 2024 12:50:25 GMT, Marius Hanl wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright year updated along with minor spcae related review
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/S
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
copyright year updated along with minor spcae related rev
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote:
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
Also one note: The copyright year was not updated, but this could also be done
by the script afterwards I guess.
On Sun, 15 Sep 2024 12:31:03 GMT, Jay Bhaskar wrote:
> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests
> are fully compliant with the JUnit 5 framework.
There is one major issue with the parameterized test as far as I can see. Some
minor style guide things, looks g
34 matches
Mail list logo
