On Mon, 16 Sep 2024 01:23:52 GMT, Jay Bhaskar <jbhas...@openjdk.org> wrote:
>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests >> are fully compliant with the JUnit 5 framework. > > Jay Bhaskar has updated the pull request incrementally with one additional > commit since the last revision: > > converting newly added tests to JUNIT5 You need to revert the copyright year change, since you've mistakenly removed the start year. modules/javafx.web/src/test/java/test/com/sun/webkit/SharedBufferTest.java line 2: > 1: /* > 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. You removed the starting copyright year, which is not OK. I recommend to revert all of the copyright changes. Then, if you prefer, you can either update it correctly to leave the starting year, or better still, leave it alone and let the script that @arapte runs periodically take care of it. ------------- PR Review: https://git.openjdk.org/jfx/pull/1567#pullrequestreview-2306563017 PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761094620
