On Mon, 16 Sep 2024 16:19:19 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - Merge branch 'master' into testsprint >> - revert copyright date >> - Revert "copyright year updated along with minor spcae related review" >> >> This reverts commit 27275c3e06311b993e7a48eeb8616acc4cc774e8. >> - converting newly added tests to JUNIT5 >> - resolve conflict >> - copyright year updated along with minor spcae related review >> - 8339515: [TestBug] Convert web tests to JUnit 5 > > modules/javafx.web/src/test/java/test/javafx/scene/web/FormControlsTest.java > line 43: > >> 41: import org.junit.jupiter.api.extension.ExtendWith; >> 42: import org.junit.runners.Parameterized.Parameters; >> 43: import org.junit.runners.Parameterized; > > These two imports should be removed. resolved > modules/javafx.web/src/test/java/test/javafx/scene/web/SubresourceIntegrityTest.java > line 36: > >> 34: import org.junit.jupiter.api.Test; >> 35: import org.junit.jupiter.api.extension.ExtendWith; >> 36: import org.junit.runners.Parameterized.Parameters; > > This import should be removed. resoled ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761480517 PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761480209
