On Mon, 16 Sep 2024 15:49:39 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Jay Bhaskar has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - Merge branch 'master' into testsprint >> - revert copyright date >> - Revert "copyright year updated along with minor spcae related review" >> >> This reverts commit 27275c3e06311b993e7a48eeb8616acc4cc774e8. >> - converting newly added tests to JUNIT5 >> - resolve conflict >> - copyright year updated along with minor spcae related review >> - 8339515: [TestBug] Convert web tests to JUnit 5 > > modules/javafx.web/src/test/java/test/javafx/scene/web/HistoryTest.java line > 2: > >> 1: /* >> 2: * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights >> reserved. > > Year change should be reverted. already did like Copyright (c) 2011, 2022, > modules/javafx.web/src/test/java/test/javafx/scene/web/MiscellaneousTest.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights >> reserved. > > Year change should be reverted. already did like Copyright (c) 2011, 2022, ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761471586 PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761470974
