On Mon, 2 Dec 2024 17:04:06 GMT, Kevin Rushforth wrote:
>> build.gradle line 2877:
>>
>>> 2875: // Add a project declaration for each incubator module here, leaving
>>> the
>>> 2876: // incubator placeholder lines as an example.
>>> 2877: // BEGIN: incubator placeholder
>>
>> Q: maybe we shoul
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to
> document where to add your incubator mo
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Mon, 2 Dec 2024 17:22:07 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Tue, 5 Nov 2024 22:31:14 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> comm
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Sat, 23 Nov 2024 02:10:21 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commi
On Sat, 23 Nov 2024 02:10:21 GMT, Nir Lisker wrote:
> I had a look (at v2). If this approach works then it's fine for now, but it
> repeats the sin of coupling configurations of (potentially) unrelated modules
> and will increase the build time for a normal build (at least it will from
> the l
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
On Fri, 22 Nov 2024 19:57:15 GMT, Andy Goryachev wrote:
> could you create a draft PR for v2, so we can leave comments?
Done. I created Draft PR #1646
-
PR Comment: https://git.openjdk.org/jfx/pull/1616#issuecomment-2494748813
On Tue, 5 Nov 2024 22:38:52 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to
> document where to add your incubator mo
On Thu, 14 Nov 2024 09:32:33 GMT, Johan Vos wrote:
>> This PR add the necessary support for [JavaFX Incubator
>> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
>> It includes the following:
>>
>> 1. Changes to the build scripts `build.gradle` and `sett
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote:
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `set
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote:
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `set
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote:
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `set
On Tue, 29 Oct 2024 22:23:35 GMT, Kevin Rushforth wrote:
> This PR add the necessary support for [JavaFX Incubator
> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md).
> It includes the following:
>
> 1. Changes to the build scripts `build.gradle` and `set
19 matches
Mail list logo
