On Fri, 22 Nov 2024 16:36:02 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> This PR add the necessary support for [JavaFX Incubator >> Modules](https://github.com/kevinrushforth/jfx/blob/jfx.incubator/INCUBATOR-MODULES.md). >> It includes the following: >> >> 1. Changes to the build scripts `build.gradle` and `settings.gradle` to >> document where to add your incubator module. Also added `jlink` flags to not >> resolve incubator modules by default and warn when resolving (same as is >> done for JDK incubator modules). >> 2. A utility class to produce warnings when first using an incubator module. >> 3. Changes to `javafx.base/module-info.java` to document where to add the >> needed qualified exports to your module to access the utility class in 2. >> >> See PR #1617 for a sample module that is built on top of this PR's source >> branch. >> >> This is almost ready to review. I will take it out of Draft in the next day >> or so. > > Kevin Rushforth has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into 8309381-incubator.dev > - Remove call to doPrivileged > - 8309381: Support JavaFX incubator modules I had a look (at v2). If this approach works then it's fine for now, but it repeats the sin of coupling configurations of (potentially) unrelated modules and will increase the build time for a normal build (at least it will from the looks of it). It can be fix as part of the cleanup, but I don't see an easy way to make it work "properly" with the current setup. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1616#issuecomment-2495219142
