On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Wed, 3 May 2023 21:22:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Wed, 3 May 2023 21:05:15 GMT, Nir Lisker wrote:
>> I thought it's only in jdk, not jfx. @kevinrushforth could you confirm that?
>
> We use the script every release.
Yes, we run a copyright update script a couple times a release, so I don't
bother updating the copyright year for existing fil
On Wed, 3 May 2023 21:11:11 GMT, Marius Hanl wrote:
> I don't think it is necessary. If you actually look at the `children` list it
> already takes care about layouting stuff and more. So requesting it here for
> every change seems wrong. But this should be tested carefully.
that's what I thou
On Wed, 3 May 2023 21:18:10 GMT, Marius Hanl wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experienc
On Wed, 3 May 2023 21:15:11 GMT, Andy Goryachev wrote:
> that's what I thought too. just to clarify, that was a question, not a change
> request.
no problem, I asked myself the same. 😄
-
PR Comment: https://git.openjdk.org/jfx/pull/1125#issuecomment-1533762671
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, the `hgap` and the `vgap` are almost always set when
>
On Wed, 3 May 2023 20:46:16 GMT, Andy Goryachev wrote:
> Not related to these changes specifically, but why does GridPane adds a
> listener in the constructor
>
> ```
> getChildren().addListener((Observable o) -> requestLayout());
> ```
>
> and VBox/HBox do not?
I don't think it is necessary.
On Wed, 3 May 2023 20:55:42 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
>> 741:
>>
>>> 739: *
>>> 740: * @param hgap the width of the horizontal gaps between columns
>>> 741: * @param vgap the height of the vertical gaps
On Wed, 3 May 2023 20:57:53 GMT, Marius Hanl wrote:
>> There is a script that does this automatically.
>
> I will change them in my next commit. Completely forgot about them. :)
I thought it's only in jdk, not jfx. @kevinrushforth could you confirm that?
-
PR Review Comment: https
On Wed, 3 May 2023 21:03:57 GMT, Andy Goryachev wrote:
>> I will change them in my next commit. Completely forgot about them. :)
>
> I thought it's only in jdk, not jfx. @kevinrushforth could you confirm that?
We use the script every release.
-
PR Review Comment: https://git.openj
On Wed, 3 May 2023 20:34:49 GMT, Nir Lisker wrote:
>> also in the test.
>
> There is a script that does this automatically.
I will change them in my next commit. Completely forgot about them. :)
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1125#discussion_r1184273354
On Wed, 3 May 2023 20:32:55 GMT, Nir Lisker wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experience
On Wed, 3 May 2023 20:13:42 GMT, Marius Hanl wrote:
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, th
On Wed, 3 May 2023 20:23:19 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
>> 737:
>>
>>> 735: }
>>> 736:
>>> 737: /**
>>
>> we probably need to update the year `2011, 2023,` in the header
>
> also in the test.
There is a sc
On Wed, 3 May 2023 20:13:42 GMT, Marius Hanl wrote:
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, th
On Wed, 3 May 2023 20:13:42 GMT, Marius Hanl wrote:
> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
> `vgap`.
> As also written in the ticket, this is a small enhancement to improve the
> creation of a layout involving a `GridPane` without FXML.
> In my experience, th
On Wed, 3 May 2023 20:22:57 GMT, Andy Goryachev wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a
>> `vgap`.
>> As also written in the ticket, this is a small enhancement to improve the
>> creation of a layout involving a `GridPane` without FXML.
>> In my experi
19 matches
Mail list logo
