On Wed, 3 May 2023 20:22:57 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a >> `vgap`. >> As also written in the ticket, this is a small enhancement to improve the >> creation of a layout involving a `GridPane` without FXML. >> In my experience, the `hgap` and the `vgap` are almost always set when >> creating a layout with the `GridPane`, as a space between the content just >> looks much better. >> >> This also fits well with other classes like `HBox` and `VBox`, which also >> provide a constructor that accepts the spacing. > > modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line > 737: > >> 735: } >> 736: >> 737: /** > > we probably need to update the year `2011, 2023,` in the header also in the test. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1125#discussion_r1184220807
