On Wed, 3 May 2023 20:55:42 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line >> 741: >> >>> 739: * >>> 740: * @param hgap the width of the horizontal gaps between columns >>> 741: * @param vgap the height of the vertical gaps between rows >> >> I think that either >> "the width of the gaps between columns" or >> "the size of the horizontal gaps between columns" >> otherwise it gives the illusion that there is a height for the horizontal >> gap. >> >> Still reads fine as it is. > > I copied that mostly from the javadoc of `hgapProperty` and `vgapProperty`. > Tbh I like `the size of the horizontal gaps between columns` more as well. > But then we are not consistent with the javadoc of the property. I'm fine > either way, just that was my intention. :) I prefer the better phrasing over the consistent one :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1125#discussion_r1184282904
