On Wed, 3 May 2023 20:32:55 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> This PR adds a new constructor to `GridPane` that accepts a `hgap` and a >> `vgap`. >> As also written in the ticket, this is a small enhancement to improve the >> creation of a layout involving a `GridPane` without FXML. >> In my experience, the `hgap` and the `vgap` are almost always set when >> creating a layout with the `GridPane`, as a space between the content just >> looks much better. >> >> This also fits well with other classes like `HBox` and `VBox`, which also >> provide a constructor that accepts the spacing. > > modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line > 741: > >> 739: * >> 740: * @param hgap the width of the horizontal gaps between columns >> 741: * @param vgap the height of the vertical gaps between rows > > I think that either > "the width of the gaps between columns" or > "the size of the horizontal gaps between columns" > otherwise it gives the illusion that there is a height for the horizontal gap. > > Still reads fine as it is. I copied that mostly from the javadoc of `hgapProperty` and `vgapProperty`. Tbh I like `the size of the horizontal gaps between columns` more as well. But then we are not consistent with the javadoc of the property. I'm fine either way, just that was my intention. :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1125#discussion_r1184271144
