Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-11-01 Thread Kevin Rushforth
On Tue, 29 Oct 2024 19:38:01 GMT, Andy Goryachev wrote: >> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java >> line 34: >> >>> 32: * For that, use {@link Marker}. >>> 33: */ >>> 34: public final class TextPos implements Comparable { >> >> Remind

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-30 Thread Andy Goryachev
On Fri, 25 Oct 2024 17:59:31 GMT, Kevin Rushforth wrote: > we need to figure out the best way to constrain the `model` property of the > RTA superclass. Are you saying that the mechanism in CodeArea:92 is not suitable? - PR Comment: https://git.openjdk.org/jfx/pull/1524#issuecomme

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-30 Thread Andy Goryachev
On Fri, 25 Oct 2024 17:34:32 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-29 Thread Andy Goryachev
On Fri, 25 Oct 2024 17:50:34 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-29 Thread Andy Goryachev
On Fri, 25 Oct 2024 17:32:40 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-29 Thread Andy Goryachev
On Fri, 25 Oct 2024 17:31:30 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/SideDecorator

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-28 Thread Andy Goryachev
On Wed, 23 Oct 2024 09:36:56 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Highligh

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-28 Thread Andy Goryachev
On Wed, 23 Oct 2024 09:36:18 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Highligh

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-25 Thread Kevin Rushforth
On Mon, 21 Oct 2024 18:53:20 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-23 Thread Ajit Ghaisas
On Mon, 21 Oct 2024 18:53:20 GMT, Andy Goryachev wrote: >> Incubating a new feature - rich text control, **RichTextArea**, intended to >> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. >> The main design goal is to provide a control that is complete enough to be >> u

Re: RFR: 8301121: RichTextArea Control (Incubator) [v28]

2024-10-21 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl