On Fri, 25 Oct 2024 17:31:30 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> break iterator
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/SideDecorator.java
> line 58:
>
>> 56: * measurement Node, whose preferred width will be used to size all
>> the side Nodes (and must, therefore,
>> 57: * be wider than any side node in the view). The {@code modelIndex}
>> is this case is the index of
>> 58: * the first paragraph in the view.
>
> After reading it a couple of times, I think I now understand what this does.
> This is used to measure the pref width of the currently visible viewport
> being displayed by the RichTextArea, right? This could be clarified a bit.
>
> Somewhat related, it might be cleaner and easier to explain / document if you
> defined a second method, `getMeasurementNode(modelIndex)` rather than using a
> boolean parameter. What do you think?
good idea, let me think about it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821220052
