On Fri, 25 Oct 2024 17:34:32 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> break iterator > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/TextPos.java > line 47: > >> 45: * @param offset the text offset >> 46: * @param charIndex the character index >> 47: * @param leading true if leading > > This needs a better description of what the parameters mean. I can't tell > from just reading the docs what the difference is between "offset" and > "charIndex". And you don't define "leading" -- I presume you mean related to > the cursor? If so, what is its meaning if the TextPos isn't being used as the > position of a cursor? Please see if the new description is better. This class is similar to HitInfo. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1823024666
