On Tue, 14 May 2024 13:37:32 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> Ok, I've updated the CSR accrodingly together with
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Wed, 22 May 2024 08:36:22 GMT, eduardsdv wrote:
>>> @johanvos added a question in the CSR about this last part:
>>>
>>> > I understand and agree with the goal behind this.
>>> > I'm a bit confused though about the following: "...but it does not
>>> > necessarily have to be the same value." -
On Wed, 22 May 2024 06:39:18 GMT, Johan Vos wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1918:
>>
>>> 1916: * Returns the length of the viewport portion of the {@code
>>> VirtualFlow} as computed during the layout pass.
>>> 1917:
On Tue, 21 May 2024 21:55:30 GMT, Kevin Rushforth wrote:
> @johanvos added a question in the CSR about this last part:
>
> > I understand and agree with the goal behind this.
> > I'm a bit confused though about the following: "...but it does not
> > necessarily have to be the same value." -> ca
On Fri, 17 May 2024 07:28:44 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Fri, 17 May 2024 07:28:44 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 16 May 2024 19:36:00 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> modules/javafx.controls/src/main/java/javafx/scene/co
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Fri, 17 May 2024 07:23:45 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Tue, 14 May 2024 13:37:32 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> Ok, I've updated the CSR accrodingly together with
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 14 May 2024 14:44:58 GMT, Johan Vos wrote:
> I'm not sure I understand the question
I thought there were specific comments somewhere in the code. Never mind then.
Thank you for responding!
-
PR Comment: https://git.openjdk.org/jfx/pull/1326#issuecomment-2110915337
On Thu, 9 May 2024 17:45:39 GMT, Andy Goryachev wrote:
> > the idea about mapping scroll events to the top/bottom of a cell is hinted
> > in the code though
>
> could you please point to these places?
I'm not sure I understand the question, as this is exactly what the PR is
doing. The scrollT
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Fri, 10 May 2024 09:26:18 GMT, Florian Kirmaier
wrote:
> I've added eduard as a contributor!
>
> **CSR** I've created a CSR. https://bugs.openjdk.org/browse/JDK-8332041
Thanks!
> If i remember correctly, the name of the ticket and the CSR must be the same?
> Otherwise i could change it to
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 9 May 2024 17:34:11 GMT, Johan Vos wrote:
> the idea about mapping scroll events to the top/bottom of a cell is hinted in
> the code though
could you please point to these places?
I think this change is inline with the modern UIs, at least macOS and Windows.
As Eduard correctly point
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 9 May 2024 14:31:56 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Mage getViewportLength() public and use it instead of
>> getBlockIncrement()
>
> modules/javafx.con
On Wed, 13 Mar 2024 08:55:14 GMT, Florian Kirmaier
wrote:
>> @FlorianKirmaier I still think this would be a good addition. I believe
>> there is only one open question (from Marius) so it would be great if you
>> can answer that.
>
> @johanvos
> Great to see you would like to see it merged!
>
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Thu, 9 May 2024 10:01:34 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 9 May 2024 09:04:54 GMT, Johan Vos wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Use viewport length as block increment
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Wed, 13 Mar 2024 08:55:14 GMT, Florian Kirmaier
wrote:
>> @FlorianKirmaier I still think this would be a good addition. I believe
>> there is only one open question (from Marius) so it would be great if you
>> can answer that.
>
> @johanvos
> Great to see you would like to see it merged!
>
On Tue, 7 May 2024 09:44:08 GMT, eduardsdv wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Use viewport length as block increment
>
> In my opinion, this PR is now ready.
should the contributor in
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 6 May 2024 18:05:06 GMT, Andy Goryachev wrote:
>> I agree with you, at least with scrolling when clicking on the scrollbar
>> track.
>> I would like to change the amount of scroll pixels to the viewport length.
>>
>> PageUp/PageDown not only scrolls the view, but also moves the
>> sel
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 6 May 2024 17:54:44 GMT, eduardsdv wrote:
> PageUp/PageDown not only scrolls the view, but also moves the
> selection/focus, so it makes sense to align the cells up/down.
You are right about focus/selection!
This brings up another question: for accessibility reasons, do we want to add
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 6 May 2024 16:35:14 GMT, Andy Goryachev wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one
>> cell is visible
>
> modules/javafx.
On Mon, 6 May 2024 16:34:22 GMT, Andy Goryachev wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one
>> cell is visible
>
> modules/javafx.
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 11 Jan 2024 12:17:11 GMT, Marius Hanl wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
>> t
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 19 Mar 2024 12:02:14 GMT, Marius Hanl wrote:
> But is it possible to scroll to an index that is negative?
Yes, both the negative value (``-1``) and the positive value, which is greater
than the items count (to be precise ``last item index + 1``), are possible and
indicate the direction
On Sun, 17 Mar 2024 17:59:07 GMT, Johan Vos wrote:
>> As I was also involved in fixing this error, I can answer.
>>
>> The `getAvailableCell()` method creates a new cell if none exists for the
>> specified index (-1).
>> The `getCell()` returns the `accumCell` in this case, which is completely
On Sun, 17 Mar 2024 18:07:35 GMT, Johan Vos wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 11 Mar 2024 15:18:51 GMT, eduardsdv wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 1556:
>>
>>> 1554: if (targetCell != null) {
>>> 1555: if (targetIndex < 0) {
>>> 1556: T cell = getCell(targetIndex
On Tue, 5 Mar 2024 09:54:43 GMT, Johan Vos wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> @FlorianKirmaier I still think this would be a good addition
On Mon, 5 Feb 2024 09:53:23 GMT, Marius Hanl wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> modules/javafx.controls/src/main/java/javafx/scene/control
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Fri, 12 Jan 2024 23:24:19 GMT, Andy Goryachev wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511
>> reverted accidental indentation chang
>
> modules/javafx.controls/src/main/java/javafx/scene/con
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Fri, 12 Jan 2024 23:44:14 GMT, Andy Goryachev wrote:
> 1. With variable height cells: if I click below the scrollbar thumb, followed
> by a click above the thumb, I expect the view to go back to the same position
> exactly, but it does not (see the screenshots). I think I've mentioned this
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
On Wed, 10 Jan 2024 12:31:20 GMT, Florian Kirmaier
wrote:
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
>
As seen in the unit test of the PR, when we click on the area above/below the
scrollbar the position jumps - but the jump is now not always consistent.
In the current version on the last cell - the UI always jumps to the top. In
the other cases, the assumed default cell height is used.
With this
70 matches
Mail list logo
