On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In >> the other cases, the assumed default cell height is used. >> >> With this PR, always the default cell height is used, to determine how much >> is scrolled. >> This makes the behavior more consistent. >> >> Especially from the unit-test, it's clear that with this PR the behavior is >> much more consistent. >> >> This is also related to the following PR: >> https://github.com/openjdk/jfx/pull/1194 > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8323511: Adjust javadoc of the getViewportLength() I've added eduard as a contributor! **CSR** I've created a CSR. https://bugs.openjdk.org/browse/JDK-8332041 If i remember correctly, the name of the ticket and the CSR must be the same? Otherwise i could change it to something like "JavaFX, add the method double VirtualFlow.getViewportLength()" ------------- PR Comment: https://git.openjdk.org/jfx/pull/1326#issuecomment-2104269970
