On Mon, 6 May 2024 16:34:22 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one >> cell is visible > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line 1804: > >> 1802: >> 1803: /** >> 1804: * The amount of pixels by which to adjust the position when the >> the scroll bar track is clicked. > > should it be the height of the viewport, so to speak? Yes, that would also be my favorite choice for the click on the scrollbar track as well as for the PageUp/PageDown. But for reasons of backwards compatibility, I didn't want to change it here. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1326#discussion_r1591295131
