On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Thu, 7 Nov 2024 18:44:23 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
> Public focus traversal API for use in custom controls.
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This is a lightweight change that only adds the public API for focus
> traversal, containing neither the public API for the traversal p
On Thu, 7 Nov 2024 18:20:36 GMT, Michael Strauß wrote:
> tests should also assert the `focusVisible` flag
good point, thanks!
-
PR Comment: https://git.openjdk.org/jfx/pull/1628#issuecomment-2462968353
On Thu, 7 Nov 2024 15:52:04 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
> Public focus traversal API for use in custom controls.
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This is a lightweight change that only adds the public API for focus
> traversal, containing neither the public API for the traversal p
On Wed, 6 Nov 2024 22:09:31 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Wed, 6 Nov 2024 22:09:31 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
> Public focus traversal API for use in custom controls.
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This is a lightweight change that only adds the public API for focus
> traversal, containing neither the public API for the traversal p
On Wed, 6 Nov 2024 20:49:20 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
On Wed, 6 Nov 2024 20:49:20 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls.
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This is a lightweight change that only adds the public API for focus
>> t
> Public focus traversal API for use in custom controls.
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This is a lightweight change that only adds the public API for focus
> traversal, containing neither the public API for the traversal p
Public focus traversal API for use in custom controls.
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
This is a lightweight change that only adds the public API for focus traversal,
containing neither the public API for the traversal policy (#1555
On Thu, 31 Oct 2024 14:58:12 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Wed, 30 Oct 2024 20:23:19 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10447:
>
>> 10445: *
>
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Wed, 30 Oct 2024 15:02:30 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Tue, 29 Oct 2024 20:06:24 GMT, Andy Goryachev wrote:
> Getting back to the API, are you ok with dropping the boolean `visible`
> argument and documenting the expectation of the key event?
Yes, I think that's okay.
-
PR Comment: https://git.openjdk.org/jfx/pull/1604#issuecomment
On Tue, 29 Oct 2024 18:14:31 GMT, Michael Strauß wrote:
> Just to complete the picture, I also want to explain why I am strongly
> against making `focusVisible` writable.
I don't disagree, I'm just a bit on the fence if making it writable by proxy is
a good idea then when it is a concept that
On Tue, 29 Oct 2024 21:53:06 GMT, Nir Lisker wrote:
> In that case, you are right. I don't have a strong opinion as I am not an
> advanced user of focus. The current behavior is good enough for me.
>
> By the way, if you have multiple scenes in the stage, and each one has its
> own focused nod
On Tue, 29 Oct 2024 21:47:53 GMT, John Hendrikx wrote:
> > > Also something that just occurred to me, but perhaps I'm late to the
> > > party; with the current API being on `Node` you could call
> > > `requestFocusTraversal` on basically any `Node`, even one that is
> > > currently not focused
On Tue, 29 Oct 2024 21:31:59 GMT, John Hendrikx wrote:
> ps. the diff for this PR still looks huge here?
Mainly because of TraversalEngine -> TraversalPolicy refactoring and skins.
And yes, one can call requestFocusTraversal on any Node, focusable or not.
There was some language to that effec
On Tue, 29 Oct 2024 21:40:45 GMT, Nir Lisker wrote:
> > Also something that just occurred to me, but perhaps I'm late to the party;
> > with the current API being on `Node` you could call `requestFocusTraversal`
> > on basically any `Node`, even one that is currently not focused. I'm not
> > s
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 21:31:59 GMT, John Hendrikx wrote:
> Also something that just occurred to me, but perhaps I'm late to the party;
> with the current API being on `Node` you could call `requestFocusTraversal`
> on basically any `Node`, even one that is currently not focused. I'm not sure
> i
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 19:33:20 GMT, Andy Goryachev wrote:
> It's one of the falsehoods programmers should be aware of.
>
> But regardless of how they interact with the UI, the focus indicator should
> always indicate the focus owner, no? There might be levels of indication,
> such as grayed focu
On Tue, 29 Oct 2024 17:55:55 GMT, Michael Strauß wrote:
> users of a GUI will interact with a mouse (or touch), not with the keyboard.
It's one of the falsehoods programmers should be aware of.
But regardless of how they interact with the UI, the focus indicator should
always indicate the foc
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 17:50:17 GMT, Andy Goryachev wrote:
>> Is there really no conceivable scenario in which this method could
>> legitimately be called _not_ in response to a key event, or is it simply
>> that we're not thinking of such a scenario right now? I'd be bothered by an
>> API that w
On Tue, 29 Oct 2024 17:46:48 GMT, Michael Strauß wrote:
>>> What happens when a different type of event is created by a `KeyEvent`
>>> handler? How does the downstream code differentiate between the secondary
>>> events coming from a key event handler vs. from one originated normally?
>>
>> Th
On Tue, 29 Oct 2024 17:44:21 GMT, Andy Goryachev wrote:
> A general question: what would be an example of when `focused !=
> focusVisible` (and `!= focusWithin`) ?
>
> Shouldn't the `focused` be a sort of "primary" property, and all other
> derived from it?
>
> What is the purpose of `focusVi
On Mon, 28 Oct 2024 19:20:28 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Tue, 29 Oct 2024 16:07:17 GMT, John Hendrikx wrote:
>> That seems reasonable, given that it is the expected use case. I wouldn't
>> say "_must_ be called", but rather that it "is _expected_ to be called" in
>> response to a KeyEvent, and then document the behavior accordingly --
>> namely,
On Tue, 29 Oct 2024 17:03:01 GMT, Jeanette Winzenburg
wrote:
>> I think this discussion is not productive. Can we focus on essentials
>> please?
>
> readability __is__ essential ;) Same as others, wondering why you insist on
> not going to max it?
I agree with readability. At the same time,
On Tue, 29 Oct 2024 15:28:39 GMT, Andy Goryachev wrote:
>> I agree that especially when each switch case is on a single line, indenting
>> is the most sensible thing to do. It's a little more defensible to treat the
>> standard switch `case :`, on a line by itself, as a label which is
>> p
On Tue, 29 Oct 2024 16:51:33 GMT, Andy Goryachev wrote:
>> I'm not sure why this is a counter argument. It's not used in the JDK or
>> JavaFX. I still think option 2 is better, but if we don't enforce a style
>> then it's your choice.
>
> I think this discussion is not productive. Can we focus
On Tue, 29 Oct 2024 16:15:45 GMT, Nir Lisker wrote:
>> That isn't an example of "everything on one line". That's effectively the
>> "switch case :, on a line by itself", which is defensible, although
>> still not preferred.
>>
>> Anyway, what you currently have is what I called option 1, a
On Tue, 29 Oct 2024 15:21:50 GMT, Kevin Rushforth wrote:
>> What happens when a different type of event is created by a `KeyEvent`
>> handler? How does the downstream code differentiate between the secondary
>> events coming from a key event handler vs. from one originated normally?
>>
>>> Is
On Tue, 29 Oct 2024 16:00:43 GMT, Kevin Rushforth wrote:
>> Sure:
>>
>>
>> String s = switch(val) {
>> case 1 ->
>> "one";
>> case 2 ->
>> "two";
>> default ->
>> "unknown";
>> };
>
> That isn't an example of "everything on one line". That's effectively the
> "switch case :, on
On Tue, 29 Oct 2024 15:16:59 GMT, Kevin Rushforth wrote:
>> This is a bit silly. You have an opening brace, you should be indenting as
>> you would in every other case when an opening brace appears and you break
>> off the line. So unless there is a **really** good reason to suddenly not
>>
On Tue, 29 Oct 2024 14:45:53 GMT, Andy Goryachev wrote:
>> I think it could be possible, but I'm not sure if it would be pretty. Scene
>> is the one dispatching these events, and since FX has a single threaded
>> model, Scene could have a flag that indicates it is currently dispatching a
>> k
On Mon, 28 Oct 2024 22:36:50 GMT, John Hendrikx wrote:
>>> I don't indent case labels inside of switch.
>>
>> Our typical code style is to indent. I don't have a strong preference, but I
>> switched (pun intended) many years ago from not indenting to always
>> indenting because: A) the IDEs (a
On Tue, 29 Oct 2024 13:01:08 GMT, John Hendrikx wrote:
>> This is better than the previous, since it only asks the caller of this
>> method, typically the Skin of a custom control, to provide the one missing
>> piece of information -- whether or not the method is in response to keyboard
>> nav
On Tue, 29 Oct 2024 12:23:59 GMT, Kevin Rushforth wrote:
>> How about this for `focusVisible`:
>>
>> /**
>> * Indicates whether this {@code Node} should visibly indicate focus.
>> *
>> * This flag is set when the node is {@link #focusedProperty() focused}
>> via keyboard nav
On Mon, 28 Oct 2024 23:53:44 GMT, Michael Strauß wrote:
>> Perhaps we need to further clarify what the focused/focusVisible/focusWithin
>> properties are for?
>
> How about this for `focusVisible`:
>
> /**
> * Indicates whether this {@code Node} should visibly indicate focus.
> *
On Mon, 28 Oct 2024 23:20:49 GMT, Andy Goryachev wrote:
>>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>>> it?
>>
>> That's easy: because we didn't deem it necessary. Back when we added the
>> flag, only internal code would be able to set it, and that has worke
On Mon, 28 Oct 2024 23:13:50 GMT, Michael Strauß wrote:
>> Good question, @hjohn . Why indeed, @mstr2 ?
>
>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>> it?
>
> That's easy: because we didn't deem it necessary. Back when we added the
> flag, only internal c
On Mon, 28 Oct 2024 22:37:34 GMT, Andy Goryachev wrote:
>> If this flag is suddenly so important, then why doesn't `requestFocus` have
>> it?
>>
>> I feel that we've found an internal inconsistency, and that the solution is
>> to then drop this on the user to ensure correctness (the wording "c
On Mon, 28 Oct 2024 20:00:02 GMT, Kevin Rushforth wrote:
>> I don't indent case labels inside of switch.
>> I don't think we enforce one way or the other.
>>
>> And you can't ask to make it more compact and then complain that it's more
>> compact /jk
>
>> I don't indent case labels inside of sw
On Mon, 28 Oct 2024 22:31:18 GMT, John Hendrikx wrote:
>>> I like that, it clearly explains what to do. thank you!
>>
>> I do, too. When I read the discussion up to the point Michael proposed this,
>> my thought was that the only way to solve it is with a parameter like this.
>>
>>> Somewhat t
On Mon, 28 Oct 2024 19:49:39 GMT, Kevin Rushforth wrote:
>> Somewhat tangential question: should we start placing JEPs in
>> `/doc-files/jeps` ?
>>
>> The use of private repos is ok at the initial stages of discussion, but at
>> some point we are risking the bit rot: private repos can be remov
On Mon, 28 Oct 2024 16:30:36 GMT, Andy Goryachev wrote:
> I don't indent case labels inside of switch.
Our typical code style is to indent. I don't have a strong preference, but I
switched (pun intended) many years ago from not indenting to always indenting
because: A) the IDEs (at least most
On Mon, 28 Oct 2024 19:23:18 GMT, Andy Goryachev wrote:
>> also updated the JEP:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> Somewhat tangential question: should we start placing JEPs in
> `/doc-files/jeps` ?
>
> The use of private repo
On Mon, 28 Oct 2024 19:20:51 GMT, Andy Goryachev wrote:
>> I like that, it clearly explains what to do. thank you!
>
> also updated the JEP:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
Somewhat tangential question: should we start placing JE
On Mon, 28 Oct 2024 19:03:41 GMT, Andy Goryachev wrote:
>> What do you think of the following:
>>
>> * @param visible Specifies whether the {@link #focusVisibleProperty()
>> focusVisible} flag will be
>> *set on the node that receives focus. Callers must specify
>> {@code true}
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 18:35:23 GMT, Andy Goryachev wrote:
>> Let's consider a few scenarios:
>>
>> 1. A node has acquired focus via keyboard navigation. Its `focusVisible` bit
>> is set. When I press "tab", I expect the next node to also have visible
>> focus. This is the status quo.
>> 2. Same
On Mon, 28 Oct 2024 19:02:05 GMT, Michael Strauß wrote:
>> I think the javadoc for `Node.focusVisible` (and its sibling
>> `Node.focusWithin`) is rather insufficient. The JBS ticket is not a
>> normative document, perhaps this should be clarified in a follow-up ticket
>> (by moving some of th
On Mon, 28 Oct 2024 18:07:17 GMT, Michael Strauß wrote:
>> Maybe we should say that `Node.requestFocusTraversal()` should only be
>> called by custom components/skins as a response to key press? I can't see a
>> way to enforce that particular rule.
>>
>> Or perhaps `Node.focusVisible` doc sho
On Mon, 28 Oct 2024 17:43:41 GMT, Andy Goryachev wrote:
>> I just quoted you the JavaFX specification, not W3C. It very clearly says
>> that the `focusVisible` flag is only set when a node acquires focus as a
>> result of keyboard navigation. You are proposing to extend the API to change
>> fo
On Mon, 28 Oct 2024 17:37:36 GMT, Michael Strauß wrote:
>> To clarify, this PR changes nothing in the way FX behaves in relation to
>> focus. Nothing. I only provided a public API for use in custom controls.
>>
>> So whatever discrepancy between FX and w3.org spec you mention (not sure
>> w
On Mon, 28 Oct 2024 17:33:46 GMT, Andy Goryachev wrote:
>> Because `focusVisible` is specified to _only_ be set as a result of keyboard
>> navigation, not as a result of programmatic navigation.
>>
>> `Node.focusVisible` specifies:
>>
>> /**
>> * Indicates whether this {@code Node} sh
On Mon, 28 Oct 2024 17:28:55 GMT, Michael Strauß wrote:
>> I do not. Why do you say that?
>
> Because `focusVisible` is specified to _only_ be set as a result of keyboard
> navigation, not as a result of programmatic navigation.
>
> `Node.focusVisible` specifies:
>
> /**
> * Indicate
On Mon, 28 Oct 2024 16:05:40 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10443:
>>
>>> 10441: /**
>>> 10442: * Requests focus traversal from this {@code Node} in the
>>> specified direction.
>>> 10443: * A successful traversal re
On Mon, 28 Oct 2024 17:25:15 GMT, Andy Goryachev wrote:
>> So you're proposing to change the specification of `focusVisible`. That
>> needs to be discussed first.
>
> I do not. Why do you say that?
Because `focusVisible` is specified to _only_ be set as a result of keyboard
navigation, not as
On Mon, 28 Oct 2024 17:23:22 GMT, Michael Strauß wrote:
>> The rationale is that this PR does not change the way the current focus
>> subsystem works, only provides the public API.
>
> So you're proposing to change the specification of `focusVisible`. That needs
> to be discussed first.
I do n
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Mon, 28 Oct 2024 16:21:25 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10458:
>
>> 10456: case
On Mon, 28 Oct 2024 06:09:40 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10443:
>
>> 10441: /**
>
On Mon, 28 Oct 2024 16:13:37 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Sat, 26 Oct 2024 14:53:38 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10442:
>
>> 10440:
>> 10441:
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Sat, 26 Oct 2024 14:37:49 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java
> line 466:
On Sat, 26 Oct 2024 14:34:38 GMT, Nir Lisker wrote:
>> Plain `requestFocus` can also work as it can be overloaded with the
>> direction parameter.
>
> I like the overloaded `requestFocus` idea as well.
I really dislike overloading in this case - the semantics of these two methods
is totally di
On Fri, 25 Oct 2024 16:22:01 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Fri, 25 Oct 2024 16:22:01 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
On Fri, 25 Oct 2024 17:40:36 GMT, John Hendrikx wrote:
>> Of these, I like `requestFocusTraversal` best. Another alternative:
>> `requestMoveFocus`.
>
> Plain `requestFocus` can also work as it can be overloaded with the direction
> parameter.
I like the overloaded `requestFocus` idea as well.
On Fri, 25 Oct 2024 15:00:21 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10449:
>>
>>> 10447: * @since 24
>>> 10448: */
>>> 10449: public final boolean requestFocusTraversal(TraversalDirection
>>> direction) {
>>
>> possible al
On Fri, 25 Oct 2024 16:22:01 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Wed, 23 Oct 2024 22:14:20 GMT, Andy Goryachev wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> request focus traversal
>
> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 10449:
>
>> 10447:
On Wed, 23 Oct 2024 18:37:03 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
> Public focus traversal API for use in custom controls
>
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>
> This work is loosely based on the patch
> https://cr.openjdk.org/~jgiles/8061673/
>
> And is a scaled down version (with the public trav
On Wed, 23 Oct 2024 18:37:03 GMT, Andy Goryachev wrote:
>> Public focus traversal API for use in custom controls
>>
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>>
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/
Public focus traversal API for use in custom controls
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
This work is loosely based on the patch
https://cr.openjdk.org/~jgiles/8061673/
And is a scaled down version (with the public traversal policy API
90 matches
Mail list logo
