On Fri, 25 Jul 2025 23:32:04 GMT, Alexander Zuev wrote:
> Initial implementation. Note that second level menu navigation with the
> non-system menus does not work but it was not working with the current
> implementation so i am raising a new bug for tracking that but that can no
On Fri, 25 Jul 2025 22:32:36 GMT, Andy Goryachev wrote:
> Fixed an NPE in the ToolBar, looks like a corner case.
Change looks good but just for my curiosity - how do we get to this point? Any
minimal test case?
-
Marked as reviewed by kizune (Committer).
PR Review: https://git.op
On Mon, 28 Jul 2025 20:29:19 GMT, Andy Goryachev wrote:
> Question: do we need another entry for the `CustomMenuItem`? It looks like
> the VoiceOver on macOS 15.5 announces a custom menu as "`menuText,
> interactive`" which seems correct.
I don't think so - as long as they are menu items it sh
On Mon, 28 Jul 2025 20:26:35 GMT, Andy Goryachev wrote:
>> Initial implementation. Note that second level menu navigation with the
>> non-system menus does not work but it was not working with the current
>> implementation so i am raising a new bug for tracking that but that can not
>> be a sh
Initial implementation. Note that second level menu navigation with the
non-system menus does not work but it was not working with the current
implementation so i am raising a new bug for tracking that but that can not be
a showstopper for this PR.
The bug raised to track menu deficiencies JDK-
On Tue, 22 Jul 2025 17:28:22 GMT, Ambarish Rapte wrote:
> The JNI method NewObjectArray may return null, so a null check should be
> added as a precaution in methods that creates an array of Screens.
Marked as reviewed by kizune (Committer).
-
PR Review: https://git.openjdk.org/jf
On Thu, 3 Jul 2025 22:17:01 GMT, Alexander Zuev wrote:
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
This pull request has now bee
On Wed, 9 Jul 2025 05:01:14 GMT, Alexander Zuev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> Alexa
On Wed, 18 Jun 2025 10:43:38 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java
>> line 349:
>>
>>> 347: flow = (VirtualFlow)control.lookup("#virtual-flow");
>>> 348:
>>> 349: if (sl != nul
On Thu, 10 Jul 2025 13:42:39 GMT, Kevin Rushforth wrote:
> This PR marks QPathTest as "unstable" on all platforms. QPathTest is known to
> timeout intermittently. See
> [JDK-8328222](https://bugs.openjdk.org/browse/JDK-8328222). It is already
> skipped on Linux, since it was causing a lot of n
On Wed, 9 Jul 2025 14:54:48 GMT, Andy Goryachev wrote:
>> But that would require two conditions - one for position and one for size -
>> with the same logic which would look not that compact and pretty.
>
> but it will save a couple of nanoseconds!
>
> the code is ok. one question though: what
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
Alexander Zuev has updated the pull request incrementally with one additional
commit si
On Tue, 8 Jul 2025 21:33:00 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove explicit jresult declaration
>
> modules/javafx.graphics/src/main/native-g
On Tue, 8 Jul 2025 21:31:14 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reverting the curly bracket placement
>
> modules/javafx.graphics/src/main/native-g
> - Copyright year update;
> - Introduce new function requestNodeAttribute and refactor code to use it;
> - Fix some typos;
> - Enable new code to handle TabPages since TabGroup was implemented;
Alexander Zuev has updated the pull request incrementally with one additional
commit si
On Tue, 8 Jul 2025 21:29:31 GMT, Andy Goryachev wrote:
>> - Copyright year update;
>> - Introduce new function requestNodeAttribute and refactor code to use it;
>> - Fix some typos;
>> - Enable new code to handle TabPages since TabGroup was implemented;
>
> modules/javafx.graphics/src/main/native
- Copyright year update;
- Introduce new function requestNodeAttribute and refactor code to use it;
- Fix some typos;
- Enable new code to handle TabPages since TabGroup was implemented;
-
Commit messages:
- 8361379: [macos] Refactor accessibility code to retrieve attribute by name
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote:
>> Under the hood the Keyman input method appears as a US English keyboard
>> layout. The characters attached to an NSEvent are always US English Roman
>> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
>> the corre
On Wed, 18 Jun 2025 09:04:32 GMT, Ambarish Rapte wrote:
> A simple change to remove `@Test` annotation from two graphics unit tests.
>
> The two tests have 2 test annotations `@Test` and `@RepeatedTest`, It results
> in warning message.
>
>
> WARNING: Possible configuration error: method [pub
On Wed, 11 Jun 2025 21:13:12 GMT, Alexander Zuev wrote:
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
This pull request has now been integrated.
Changeset: 48282b10
Author:Alexander Zuev
URL:
https://git.openjdk.org/jfx/
On Mon, 16 Jun 2025 05:30:53 GMT, Ambarish Rapte wrote:
> > Noticed that when the buttons show pages 11-20, the focus is on button 13,
> > it announces "you are currently on selected page, group, 3 of 10"
>
> This is observed on windows too. Seems like an existing issue, may be we
> should rep
On Mon, 16 Jun 2025 05:52:53 GMT, Ambarish Rapte wrote:
> May be can change these methods to have a helper method.
I will probably do this refactoring in a separate PR.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1823#discussion_r2150468463
On Thu, 12 Jun 2025 22:53:11 GMT, Andy Goryachev wrote:
> TabPane: can't find any differences between this PR and the master. What
> should it say differently?
Nothing. TabPane should behave exactly the same. I need to check what's going
on with pagination, but i do not think it is changed fro
On Thu, 12 Jun 2025 19:23:57 GMT, Andy Goryachev wrote:
> Also noticed to pre-existing issues (in master):
>
> * resizing the control does not update the accessibility focus rectangle
> * flipping through tabs in TabPane using left/right arrow keys sometimes
> places the accessibility focus rec
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add accessible role description to the base component
-
C
On Thu, 12 Jun 2025 18:36:31 GMT, Alexander Zuev wrote:
>> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
>> PAGINATION roles.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last re
On Wed, 11 Jun 2025 21:51:46 GMT, Andy Goryachev wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing indentation.
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXT
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing indentation.
-
Changes:
- all: https://git.openjdk.o
On Wed, 11 Jun 2025 21:13:12 GMT, Alexander Zuev wrote:
> Create implementation of the TabGroup protocol and assign it to TAB_PANE and
> PAGINATION roles.
In order to validate the fix one can use Ensemble8 demo app and go trough the
Pagination and TabPane controls, then check tha
Create implementation of the TabGroup protocol and assign it to TAB_PANE and
PAGINATION roles.
-
Commit messages:
- 8359257: Create accessibility protocol for TabGroup component
Changes: https://git.openjdk.org/jfx/pull/1823/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=
On Tue, 27 May 2025 04:18:33 GMT, Alexander Zuev wrote:
> - Initial implementation;
> - Added accessible text to image view in Ensemble8 to make testing of this
> feature with Ensemble8 more viable;
This pull request has now been integrated.
Changeset: 5d367530
Author:Alexa
- Initial implementation;
- Added accessible text to image view in Ensemble8 to make testing of this
feature with Ensemble8 more viable;
-
Commit messages:
- 8356983: Create implementation of NSAccessibilityImage protocol
Changes: https://git.openjdk.org/jfx/pull/1816/files
Webre
On Sat, 17 May 2025 12:24:46 GMT, Michael Strauß wrote:
>> When an exception is thrown from `AnimationTimer::handle`, the JavaFX
>> application freezes. The reason is that the user exception will bubble up
>> into framework code, preventing the normal operation of JavaFX.
>>
>> The following p
On Thu, 15 May 2025 15:55:41 GMT, Andy Goryachev wrote:
> typing 'h' causes this character to appear: 𐩱 typing 'n' followed by 'h'
> generates garbage input rather than expected 𐩱:
The same happens without the fix. For some reason events for the keys not
mapped on the active keyman keyboard st
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote:
> Under the hood the Keyman input method appears as a US English keyboard
> layout. The characters attached to an NSEvent are always US English Roman
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends
> the correct H
On Mon, 28 Apr 2025 04:37:59 GMT, Alexander Zuev wrote:
> Initial implementation. In order to implement progress indicator the group
> accessibility protocol has to be implemented too so this is also a fix for
> 8351773. There are commented out sections that can be used to v
On Mon, 21 Apr 2025 15:42:20 GMT, Ziad El Midaoui
wrote:
> Fixed Caret disappear after unfocus then focus on the TextArea, the issue was
> happening because the caret position was set to -1 when we focus on the
> TextArea with empty text and caused the caret to disappear from at the skin
> le
On Wed, 7 May 2025 15:43:18 GMT, Andy Goryachev wrote:
> so the group protocol is **not** needed for the progress bar/indicator?
What? It is required see the definition for the interface:
`@interface JFXProgressIndicatorAccessibility :
JFXGroupAccessibility`
-
PR Comment: h
actly in the same way as
> the code without the fix. After review is done i will remove the debug output.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
- Added newlines where they were missing;
- Removed ebug output;
On Wed, 30 Apr 2025 21:52:15 GMT, Andy Goryachev wrote:
> How can one test the group protocol change?
Right now the group protocol is only used as a parent protocol for the
composite component such as ProgressBar and the only way to properly test it is
to add the debugging output to methods su
On Mon, 28 Apr 2025 21:25:06 GMT, Andy Goryachev wrote:
> Are these changes testable? If so, could you please describe what we are
> supposed to see during the testing?
This fix covers two controls - ProgressBar and ProgressIndicator, i used
Ensemble, it has pages for both with values and just
On Mon, 28 Apr 2025 10:29:11 GMT, Ambarish Rapte wrote:
>> Initial implementation. In order to implement progress indicator the group
>> accessibility protocol has to be implemented too so this is also a fix for
>> 8351773. There are commented out sections that can be used to verify the
>> fun
Initial implementation. In order to implement progress indicator the group
accessibility protocol has to be implemented too so this is also a fix for
8351773. There are commented out sections that can be used to verify the
functionality of the code since it has to behave exactly in the same way
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote:
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
This pull request has now been integrated.
Changeset: c7091e1f
Author:Alexander Zuev
On Wed, 5 Mar 2025 16:48:22 GMT, Andy Goryachev wrote:
> so the remaining question is whether it should announce "percent" of the
> slider position or the actual value?
Unfortunately we do not have any control on that. There is no way to tell
VoiceOver if it is percent or the raw value - VO de
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Remove duplicate code make accessibi
On Mon, 3 Mar 2025 16:54:08 GMT, Alexander Zuev wrote:
> Also, for Spinner, it says "Stepper", is this expected?
On macOS the control we call Spinner is called Stepper, there's no Spinner.
>From macOS UI guide: "A stepper is a two-segment control that people use to
On Tue, 4 Mar 2025 19:32:51 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Fri, 28 Feb 2025 11:43:39 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Add accessibilityTitleUIElement function to the base class.
&g
On Fri, 28 Feb 2025 23:41:18 GMT, Andy Goryachev wrote:
> With Slider, it announces the current value as "percent" (of the working
> envelope?), even though the min/max can be arbitrary. Is this intentional?
>
> Also, for Spinner, it says "Stepper", is this expected?
>
> macOS 15.3.1 M1
I nee
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 14 commits
On Fri, 7 Feb 2025 18:43:32 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Fri, 7 Feb 2025 18:43:32 GMT, Andy Goryachev wrote:
>> Root Cause:
>> (Multiple) properties are getting bound to the global
>> `Platform.accessibilityActive` property. Binding (and I say, accessing) of
>> properties is not thread-safe.
>>
>> I also changed the design a bit. Originally, eve
On Tue, 17 Dec 2024 21:06:16 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Fri, 25 Oct 2024 22:00:37 GMT, Andy Goryachev wrote:
> A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844)
> Text/TextFlow.hitTest() introduced a regression in the
> `TextArea`/`TextField`/`PasswordField` in the RTL mode.
>
> The fix is to flip the x coordinates when needed
On Fri, 25 Oct 2024 22:00:37 GMT, Andy Goryachev wrote:
> A fix for [JDK-8319844](https://bugs.openjdk.org/browse/JDK-8319844)
> Text/TextFlow.hitTest() introduced a regression in the
> `TextArea`/`TextField`/`PasswordField` in the RTL mode.
>
> The fix is to flip the x coordinates when needed
On Tue, 29 Oct 2024 22:12:47 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Tue, 29 Oct 2024 19:56:39 GMT, Andy Goryachev wrote:
>> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/CodeTextModel.java
>> line 95:
>>
>>> 93: protected void invalidated() {
>>> 94: TextPos end = getDocumentEnd();
On Mon, 28 Oct 2024 23:01:39 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Mon, 28 Oct 2024 23:01:39 GMT, Andy Goryachev wrote:
>> Incubating a new feature - rich text control, **RichTextArea**, intended to
>> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane.
>> The main design goal is to provide a control that is complete enough to be
>> u
On Mon, 15 Jul 2024 21:12:35 GMT, Alexander Zuev wrote:
> Initial implementation of the protocol.
This pull request has now been integrated.
Changeset: 6ac2dd3e
Author: Alexander Zuev
Committer: Andy Goryachev
URL:
https://git.openjdk.org/jfx/com
> Initial implementation of the protocol.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five additional
commits since the l
On Tue, 6 Aug 2024 17:17:15 GMT, Andy Goryachev wrote:
> Item 4 seems to have been introduced by this PR - don't see the issue with
> the master branch. Also, notice that we don't get a stack trace but a bunch
> of concatenated messages.
I can not reproduce this on my build - probably because
On Tue, 30 Jul 2024 21:01:15 GMT, Andy Goryachev wrote:
> Incubating a new feature - rich text control, **RichTextArea**, intended to
> bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The
> main design goal is to provide a control that is complete enough to be useful
On Thu, 1 Aug 2024 22:41:05 GMT, Alexander Zuev wrote:
>> Initial implementation of the protocol.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing methods that supposed to generate attri
> Initial implementation of the protocol.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Removing methods that supposed to generate attributed strings. String
attributes are not available for the static text elements and ca
On Wed, 24 Jul 2024 17:03:53 GMT, Andy Goryachev wrote:
>> TextField can be scrolled horizontally, so seems like even TextField should
>> respond to SHOW_TEXT_RANGE.
>> So, instead of removing TextField mention from
>> AccessibleAction.SHOW_TEXT_RANGE, a bug can/should be filed for missing
>>
On Tue, 23 Jul 2024 14:55:49 GMT, Andy Goryachev wrote:
>> Minor clarifications in Javadoc
>>
>> **AccessibleAttribute**:
>> - Point2D and Bound values uses screen coordinates. Example: `BOUNDS`,
>> `BOUNDS_FOR_RANGE`, `OFFSET_AT_POINT`, ...
>> - clarified the meaning of `SELECTION_END`, `SELEC
> Initial implementation of the protocol.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add comment about AccessibleRole enuM
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1507/files
- new: ht
On Tue, 16 Jul 2024 17:41:18 GMT, Andy Goryachev wrote:
>> Initial implementation of the protocol.
>
> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
> 53:
>
>> 51: [rolesMap setObject:@"JFXCheckboxAccessibility" forKey:@"CHECK_BOX"];
>> 52: [rolesMap setOb
Initial implementation of the protocol.
-
Commit messages:
- 8336031: Create implementation of NSAccessibilityStaticText protocol
Changes: https://git.openjdk.org/jfx/pull/1507/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1507&range=00
Issue: https://bugs.openjdk.org/b
On Mon, 8 Apr 2024 18:19:22 GMT, Alexander Zuev wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Mon, 1 Apr 2024 19:27:17 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT (option-command-LEFT/RIGHT) key bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal scrolling. The main reason for the
>> change is to improv
On Fri, 5 Apr 2024 21:09:34 GMT, Alexander Zuev wrote:
> Backport from mainline. Changes can be applied cleanly.
This pull request has now been integrated.
Changeset: 1e21a6f3
Author: Alexander Zuev
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx22u/com
Backport from mainline. Changes can be applied cleanly.
-
Commit messages:
- Backport 0eb4d7196099d817cc6467985b882242845bdd2e
Changes: https://git.openjdk.org/jfx22u/pull/25/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=25&range=00
Issue: https://bugs.openjdk.org/br
On Thu, 4 Apr 2024 21:55:11 GMT, Alexander Zuev wrote:
> Added missing checks;
> Added a manual regression test;
This pull request has now been integrated.
Changeset: 0eb4d719
Author:Alexander Zuev
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/
Added missing checks;
Added a manual regression test;
-
Commit messages:
- 8329705: Add missing Application thread checks to platform specific a11y
methods
- Merge pull request #8 from openjdk/master
- Merge pull request #7 from openjdk/master
Changes: https://git.openjdk.org/jfx
On Wed, 14 Feb 2024 02:55:15 GMT, Ambarish Rapte wrote:
>> This is accessibility specific fix.
>>
>> **Issue**: When a ListView is shown for first time then accessibility focus
>> rectangle is not drawn around the focused ListIem
>>
>> **Cause:**
>>The ListView takes a little time to crea
On Wed, 30 Aug 2023 14:21:48 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add commented out debug statements.
>
> I observed few warnings and behavioral
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Adding accessibilityMin
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
On Wed, 8 Nov 2023 19:43:24 GMT, Kevin Rushforth wrote:
>> Fix [JDK-8319669](https://bugs.openjdk.org/browse/JDK-8319669) as follows:
>>
>> 1. Override the `NSApplicationDelegate` method
>> `applicationSupportsSecureRestorableState` in `GlassApplication` and return
>> `YES`. This silences the
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing warnings dur
On Tue, 29 Aug 2023 19:45:32 GMT, Andy Goryachev wrote:
> what I meant is that commented out logging statements should be left in the
> code, so the reviewers can uncomment them and test. like this:
>
> ```
> // System.err.println("it works");
> ```
Did that. I would just appreciate if you or
> Create implementation for Slider and Stepper accessibility protocols.
> Fix mapping.
> Fix performAction parameter type in declaration.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add commented out debug s
On Tue, 29 Aug 2023 15:18:20 GMT, Kevin Rushforth wrote:
> Having said that, it would be helpful for Alex to list the controls that will
> use the new implementation, so reviewers can test it manually.
I will definitely do that in the future. In this case you are right the
controls are Spinner
On Tue, 29 Aug 2023 15:55:13 GMT, Andy Goryachev wrote:
> perhaps the logging statements should be added (commented out) as a part of
> this PR.
I can do that - i usually refrained from doing so because code would look not
very clean but basically the only way to tell that it goes trough the n
Create implementation for Slider and Stepper accessibility protocols.
Fix mapping.
Fix performAction parameter type in declaration.
-
Commit messages:
- 8313556: Create implementation of NSAccessibilitySlider protocol
Changes: https://git.openjdk.org/jfx/pull/1226/files
Webrev: ht
On Sun, 23 Jul 2023 20:35:53 GMT, Alexander Zuev wrote:
> also
> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>
> Create implementation of NSAccessibilityCheckBox and
> NSAccessibilityRadioButton protocols
> Add workaround for the wrong focus owner
On Mon, 14 Aug 2023 18:38:39 GMT, Alexander Zuev wrote:
>> also
>> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>>
>> Create implementation of NSAccessibilityCheckBox and
>> NSAccessibilityRadioButton protocols
>> Add workaround fo
On Mon, 7 Aug 2023 14:10:09 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
>> 174:
>>
>>> 172: jobject jresult = NULL;
>>> 173: GET_MAIN_JENV;
>>> 174: if (env == NULL) return NULL;
>>
>> This generates a warning:
>> `war
ong magnifier text on buttons
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Comment out TAB_ITEM until the TAB_GROUP is properly implemented in the new
API
Make isAccessibilityFocused to always return a proper value
--
ong magnifier text on buttons
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Add newline at the end of the header files.
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1184/files
- new: https://git.openjdk.or
also
8309629: Create implementation of NSAccessibilityRadioButton protocol
Create implementation of NSAccessibilityCheckBox and NSAccessibilityRadioButton
protocols
Add workaround for the wrong focus owner announcement with radio buttons
Add workaround for wrong magnifier text on buttons
---
On Tue, 18 Jul 2023 20:17:13 GMT, Alexander Zuev wrote:
> Backport of the JDK-8311806 from main branch.
This pull request has now been integrated.
Changeset: 529d4796
Author: Alexander Zuev
Committer: Kevin Rushforth
URL:
https://git.openjdk.org/jfx/com
Backport of the JDK-8311806 from main branch.
-
Commit messages:
- Backport ad5e66a7ca31994ecbdae3fc7d0b951e0a6f8197
Changes: https://git.openjdk.org/jfx/pull/1179/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1179&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8311
On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev wrote:
> To avoid confusion on the os x dynamic linker side i renamed native classes
> from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix
> down the line to avoid any confusion when running with the latest JDK tha
On Thu, 13 Jul 2023 05:25:45 GMT, Ambarish Rapte wrote:
> May I suggest an alternate naming pattern similar to AccessibleBase.h. Can we
> name our files as AccessibleButton, (AccessibleList, ... and so forth) ?
The slight issue with this approach is that in my opinion the class names will
be t
On Tue, 11 Jul 2023 20:12:44 GMT, Kevin Rushforth wrote:
> Is there a way to hide the symbols so that they are not exported?
I do not think we can hide these symbols from the library - they have to be
public for us to instantiate them dynamically based on the accessibility role
of the FX node.
1 - 100 of 141 matches
Mail list logo
