On Mon, 28 Jul 2025 20:26:35 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Initial implementation. Note that second level menu navigation with the >> non-system menus does not work but it was not working with the current >> implementation so i am raising a new bug for tracking that but that can not >> be a showstopper for this PR. >> >> The bug raised to track menu deficiencies JDK-8364133 > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 43: > >> 41: * enum javafx.scene.AccessibleRole >> 42: */ >> 43: rolesMap = [[NSMutableDictionary alloc] initWithCapacity:21]; > > would it make more sense to set the expected size once and for all? Well, right now i can not predict what would be the size of this dictionary. More than 21 but for sure less than 100. And it does not bother me to increase the capacity when i add new implementations - on the contrary, sometimes i recount components and check the capacity - and that is how i can catch the discrepancy when i implemented a component but forgot to add it to the dictionary :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1858#discussion_r2238163971
