On Tue, 8 Jul 2025 21:29:31 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> - Copyright year update; >> - Introduce new function requestNodeAttribute and refactor code to use it; >> - Fix some typos; >> - Enable new code to handle TabPages since TabGroup was implemented; > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 50: > >> 48: [rolesMap setObject:@"JFXButtonAccessibility" >> forKey:@"SPLIT_MENU_BUTTON"]; >> 49: [rolesMap setObject:@"JFXRadiobuttonAccessibility" >> forKey:@"RADIO_BUTTON"]; >> 50: [rolesMap setObject:@"JFXRadiobuttonAccessibility" >> forKey:@"TAB_ITEM"]; > > this change seems unrelated - is it a part of some other work? When i implemented radio buttons one of the roles this implementation was supposed to fulfill was tab button for the tabbed pane. But without the new implementation of Tab Group it did not work - focus was funky and announcement was not correct. So i commented out this role assignment. When i pushed Tab Group implementation i haven't uncommented this line so now since i do clean up and refactoring on this exact file i tested that now it works properly and uncommented it. Just trying not to spawn too many pull requests for the minimal changes. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1840#discussion_r2193974994
