Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-16 Thread Martin Fox
On Fri, 16 May 2025 23:02:30 GMT, Andy Goryachev wrote: > It is weird that we have to add third-party specific code to JavaFX as a > workaround - why doesn't macOS provide a general purpose API for this? Normally an input method is designed for a specific language and is bundled with a collect

Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-16 Thread Martin Fox
On Fri, 16 May 2025 23:13:43 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Second try at making Keyman work to some extent > > modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m lin

Re: RFR: 8356690: Update JUnit to 5.12.2

2025-05-16 Thread Kevin Rushforth
On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote: > This PR bumps the JUnit version to 5.12.2. > Also removed 2 now unused variables since I phased out the JUnit Vintage > Engine + Hamcrest. > > Changelog: > https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2

Re: Headless Platform module?

2025-05-16 Thread Kevin Rushforth
Interesting questions. There are two high level questions here (I think). First, should the Monocle headless platform be part of the javafx.graphics module or should it be a separate module? Second, should the headless "platform" be considered a completely different OS platform or, since it is

Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote: >> Under the hood the Keyman input method appears as a US English keyboard >> layout. The characters attached to an NSEvent are always US English Roman >> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends >> the corre

Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 22:25:20 GMT, Martin Fox wrote: >> Under the hood the Keyman input method appears as a US English keyboard >> layout. The characters attached to an NSEvent are always US English Roman >> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends >> the corre

Re: RFR: 8356652: Input field ignores custom input source characters

2025-05-16 Thread Steven Loomis
On Fri, 16 May 2025 22:21:52 GMT, Martin Fox wrote: > keeps sending backspaces to erase previous characters I do know that keyboards in general need to be able to interact with the existing context, that is, to convert h + i into ひ erasing the "h". I'm not sure of the correct mechanism here bu

Re: RFR: 8356652: Input field ignores custom input source characters

2025-05-16 Thread Martin Fox
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote: > Under the hood the Keyman input method appears as a US English keyboard > layout. The characters attached to an NSEvent are always US English Roman > even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends > the correct H

Re: RFR: 8356652: Input field ignores custom input source characters [v2]

2025-05-16 Thread Martin Fox
> Under the hood the Keyman input method appears as a US English keyboard > layout. The characters attached to an NSEvent are always US English Roman > even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends > the correct Hebrew or Dvorak character to insertText:replacementRan

Re: RFR: 8356690: Update JUnit to 5.12.2

2025-05-16 Thread Kevin Rushforth
On Sat, 10 May 2025 23:41:44 GMT, Marius Hanl wrote: > This PR bumps the JUnit version to 5.12.2. > Also removed 2 now unused variables since I phased out the JUnit Vintage > Engine + Hamcrest. > > Changelog: > https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 19:03:21 GMT, Andy Goryachev wrote: >> We could also just keep it with a fixed threshold, but remove the system >> property. > > It just seems unnecessary to add all this complexity. The first exception is > all we need, really - we can skip the 2nd, 3rd, ... This might ru

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 18:52:57 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/AbstractPrimaryTimer.java >> line 352: >> >>> 350: } >>> 351: >>> 352: private static abstract class ReceiverRecord { >> >> All this does look complicated, just

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 19:03:14 GMT, Michael Strauß wrote: >> We're throwing away all exceptions after a certain point (either after the >> first, or some number of exceptions after that). A potential use case would >> be debugging a large application that for some reason throws lots of >> differ

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 18:47:03 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/main/java/com/sun/scenario/animation/AbstractPrimaryTimer.java > l

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote: >> When an exception is thrown from `AnimationTimer::handle`, the JavaFX >> application freezes. The reason is that the user exception will bubble up >> into framework code, preventing the normal operation of JavaFX. >> >> The following p

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 18:27:14 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/main/java/com/sun/scenario/animation/AbstractPrimaryTimer.java > l

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote: >> When an exception is thrown from `AnimationTimer::handle`, the JavaFX >> application freezes. The reason is that the user exception will bubble up >> into framework code, preventing the normal operation of JavaFX. >> >> The following p

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 18:12:35 GMT, Michael Strauß wrote: >> When an exception is thrown from `AnimationTimer::handle`, the JavaFX >> application freezes. The reason is that the user exception will bubble up >> into framework code, preventing the normal operation of JavaFX. >> >> The following p

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 07:03:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
On Fri, 16 May 2025 17:51:40 GMT, Andy Goryachev wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > modules/javafx.graphics/src/main/java/com/sun/scenario/animation/AbstractPrimaryTimer.java > l

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application [v2]

2025-05-16 Thread Michael Strauß
> When an exception is thrown from `AnimationTimer::handle`, the JavaFX > application freezes. The reason is that the user exception will bubble up > into framework code, preventing the normal operation of JavaFX. > > The following program demonstrates the defect: > > > public class FailingAni

Re: RFR: 8357157: Exception thrown from AnimationTimer freezes application

2025-05-16 Thread Andy Goryachev
On Fri, 16 May 2025 14:38:20 GMT, Michael Strauß wrote: > When an exception is thrown from `AnimationTimer::handle`, the JavaFX > application freezes. The reason is that the user exception will bubble up > into framework code, preventing the normal operation of JavaFX. > > The following progra

Re: RFR: 8356652: Input field ignores custom input source characters

2025-05-16 Thread Andy Goryachev
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote: > Under the hood the Keyman input method appears as a US English keyboard > layout. The characters attached to an NSEvent are always US English Roman > even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends > the correct H

Re: RFR: 8356652: Input field ignores custom input source characters

2025-05-16 Thread Steven Loomis
On Wed, 14 May 2025 15:31:46 GMT, Martin Fox wrote: > Under the hood the Keyman input method appears as a US English keyboard > layout. The characters attached to an NSEvent are always US English Roman > even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends > the correct H

RFR: 8357157: Exception thrown from AnimationTimer freezes application

2025-05-16 Thread Michael Strauß
When an exception is thrown from `AnimationTimer::handle`, the JavaFX application freezes. The reason is that the user exception will bubble up into framework code, preventing the normal operation of JavaFX. The following program demonstrates the defect: public class FailingAnimationTimer exte

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v2]

2025-05-16 Thread John Hendrikx
On Fri, 16 May 2025 07:03:38 GMT, Lukasz Kostyra wrote: >> This follow-up change finishes the earlier changes to >> `ImageStorage.loadAll()` and adds support for loading specific scale >> requested in the input. >> >> `loadAll()` will now first check if the input path ends with a scaling level

RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-05-16 Thread Gopal Pattnaik
On loading of the reported URL, it looks like a browser version check is made (like Safari version, Chrome version etc). At present the browser version is not part of the user agent string we are using for JavaFX Webview Solution: Added a version string in the user agent similar to Safari. Veri

Re: RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-05-16 Thread Gopal Pattnaik
On Thu, 15 May 2025 12:36:22 GMT, Kevin Rushforth wrote: > This looks reasonable. Please update the description with what testing you > have done on various websites. > > I left one clarifying suggestion inline. I tested some social media and bank urls and the page was loading as expected. --

Re: RFR: 8354940: Fail to sign in to Microsoft sites with WebView

2025-05-16 Thread Kevin Rushforth
On Thu, 15 May 2025 09:26:42 GMT, Gopal Pattnaik wrote: > On loading of the reported URL, it looks like a browser version check is made > (like Safari version, Chrome version etc). At present the browser version is > not part of the user agent string we are using for JavaFX Webview > > Solutio

Headless Platform module?

2025-05-16 Thread Johan Vos
Hi, The Headless Glass Platform has been in the jfx sandbox repository [1] for some time now, and we have provided a number of builds allowing users to test the headless platform. The reactions were very positive. It's mainly being used in 2 areas: testing is obviously a major usecase, especially

Re: RFR: 8357067: Platform preference change can emit multiple notifications [v3]

2025-05-16 Thread Michael Strauß
> Some platform preference changes can trigger the emission of multiple > notifications. For example, when switching from a high-contrast theme on > Windows to the regular theme, the following notifications are emitted (log > can be viewed in `PlatformPreferencesChangedTest`): > > > changed: >

Re: RFR: 8342530: Specifying "@Nx" scaling level in ImageStorage should only load that specific level [v2]

2025-05-16 Thread Lukasz Kostyra
> This follow-up change finishes the earlier changes to > `ImageStorage.loadAll()` and adds support for loading specific scale > requested in the input. > > `loadAll()` will now first check if the input path ends with a scaling level > specified, and if that is the case it will attempt creating