On Wed, 14 May 2025 15:31:46 GMT, Martin Fox <m...@openjdk.org> wrote:

> Under the hood the Keyman input method appears as a US English keyboard 
> layout. The characters attached to an NSEvent are always US English Roman 
> even if the selected Keyman layout is, say, Hebrew or Dvorak. Keyman sends 
> the correct Hebrew or Dvorak character to insertText:replacementRange: 
> instead.
> 
> This PR special-cases the Keyman layout, detecting it using the same method 
> that AWT does. When Keyman is active Glass records the insertText: character 
> and uses that when sending out KeyEvents.

Looks reasonable to me

-------------

Marked as reviewed by srl (no project role).

PR Review: https://git.openjdk.org/jfx/pull/1805#pullrequestreview-2846964516

Reply via email to