[jfx24] RFR: 8349472: Update copyright header for files modified in 2025

2025-02-25 Thread Ambarish Rapte
Update copyright year for jfx24 release. - Commit messages: - cp year 2024 - update cp year 2025 Changes: https://git.openjdk.org/jfx/pull/1725/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1725&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349472 Stats: 65 li

Re: RFR: 8349091: Charts: exception initializing in a background thread [v6]

2025-02-25 Thread Andy Goryachev
> Root Cause: > (Multiple) properties are getting bound to the global > `Platform.accessibilityActive` property. Binding (and I say, accessing) of > properties is not thread-safe. > > I also changed the design a bit. Originally, every symbol in a chart had its > `focusTraversableProperty` boun

Integrated: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes

2025-02-25 Thread Andy Goryachev
On Sat, 15 Feb 2025 00:08:22 GMT, Andy Goryachev wrote: > ## Added Missing Controls > > ButtonBar > ProgressIndicator > Separator > Slider, > > ## Added Node Classes > > AnchorPane > AmbientLight > Arc > BorderPane > Box > Circle > CubicCurve > Cylinder > DialogPane > DirectionalLight > Ellips

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children" [v3]

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 19:05:23 GMT, Michael Strauß wrote: >> The `VetoableListDecorator` class does not override the default >> implementation of `List.sort()`. The default implementation copies the >> elements into an array, sorts the array, and then calls `List.set()` in a >> loop to sort the

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes [v2]

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 19:25:25 GMT, Andy Goryachev wrote: >> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java >> line 227: >> >>> 225: public class NodeInitializationStressTest extends RobotTestBase { >>> 226: /* debugging aid: set this flag to true and com

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes [v2]

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 20:20:27 GMT, Andy Goryachev wrote: >> ## Added Missing Controls >> >> ButtonBar >> ProgressIndicator >> Separator >> Slider, >> >> ## Added Node Classes >> >> AnchorPane >> AmbientLight >> Arc >> BorderPane >> Box >> Circle >> CubicCurve >> Cylinder >> DialogPane >> Direct

Re: RFR: 8350048: Enforce threading restrictions for show and hide methods in Window, Control, and Skin

2025-02-25 Thread Kevin Rushforth
On Wed, 19 Feb 2025 20:39:19 GMT, Andy Goryachev wrote: > - enforced fx application thread > - added a headful test `TestThreadingRestrictions` > > ## Note to the Reviewers > > To avoid merge conflicts, the preferred order of integrations: > > #1697 > #1713 > #1717 The API doc changes look

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes [v2]

2025-02-25 Thread Andy Goryachev
> ## Added Missing Controls > > ButtonBar > ProgressIndicator > Separator > Slider, > > ## Added Node Classes > > AnchorPane > AmbientLight > Arc > BorderPane > Box > Circle > CubicCurve > Cylinder > DialogPane > DirectionalLight > Ellipse > FlowPane > GridPane > Group > HBox > ImageView > Line

What is the best way to get a high frame rate in a JavaFX application?

2025-02-25 Thread Glavo
Hi, Recently I was investigating how to improve the user experience of our JavaFX applications. I noticed that JavaFX applications seem to be limited to 60fps by default, which makes JavaFX applications appear to animate less smoothly than many other applications when users are using high refresh

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes

2025-02-25 Thread Andy Goryachev
On Tue, 25 Feb 2025 17:47:47 GMT, Kevin Rushforth wrote: >> ## Added Missing Controls >> >> ButtonBar >> ProgressIndicator >> Separator >> Slider, >> >> ## Added Node Classes >> >> AnchorPane >> AmbientLight >> Arc >> BorderPane >> Box >> Circle >> CubicCurve >> Cylinder >> DialogPane >> Direc

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes

2025-02-25 Thread Andy Goryachev
On Tue, 25 Feb 2025 17:26:30 GMT, Kevin Rushforth wrote: >> ## Added Missing Controls >> >> ButtonBar >> ProgressIndicator >> Separator >> Slider, >> >> ## Added Node Classes >> >> AnchorPane >> AmbientLight >> Arc >> BorderPane >> Box >> Circle >> CubicCurve >> Cylinder >> DialogPane >> Direc

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes

2025-02-25 Thread Andy Goryachev
On Tue, 25 Feb 2025 17:03:17 GMT, Kevin Rushforth wrote: >> ## Added Missing Controls >> >> ButtonBar >> ProgressIndicator >> Separator >> Slider, >> >> ## Added Node Classes >> >> AnchorPane >> AmbientLight >> Arc >> BorderPane >> Box >> Circle >> CubicCurve >> Cylinder >> DialogPane >> Direc

Re: RFR: 8349091: Charts: exception initializing in a background thread [v5]

2025-02-25 Thread Andy Goryachev
> Root Cause: > (Multiple) properties are getting bound to the global > `Platform.accessibilityActive` property. Binding (and I say, accessing) of > properties is not thread-safe. > > I also changed the design a bit. Originally, every symbol in a chart had its > `focusTraversableProperty` boun

Re: RFR: 8349091: Charts: exception initializing in a background thread [v4]

2025-02-25 Thread Andy Goryachev
On Mon, 24 Feb 2025 23:56:01 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 22 commits: >> >> - Merge remote-tracking branch 'origin/master' into >> 8349091.charts.thread.safety >>

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children" [v3]

2025-02-25 Thread Michael Strauß
> The `VetoableListDecorator` class does not override the default > implementation of `List.sort()`. The default implementation copies the > elements into an array, sorts the array, and then calls `List.set()` in a > loop to sort the List **without removing the old elements first**. This leads

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children" [v2]

2025-02-25 Thread Michael Strauß
> The `VetoableListDecorator` class does not override the default > implementation of `List.sort()`. The default implementation copies the > elements into an array, sorts the array, and then calls `List.set()` in a > loop to sort the List **without removing the old elements first**. This leads

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children" [v2]

2025-02-25 Thread Michael Strauß
On Tue, 25 Feb 2025 16:21:30 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> factor out setAll implementation > > modules/javafx.base/src/main/java/com/sun/javafx/collections/VetoableListDeco

Re: RFR: 8349750: [TestBug] NodeInitializationStressTest: remaining Nodes

2025-02-25 Thread Kevin Rushforth
On Sat, 15 Feb 2025 00:08:22 GMT, Andy Goryachev wrote: > ## Added Missing Controls > > ButtonBar > ProgressIndicator > Separator > Slider, > > ## Added Node Classes > > AnchorPane > AmbientLight > Arc > BorderPane > Box > Circle > CubicCurve > Cylinder > DialogPane > DirectionalLight > Ellips

Integrated: 8347753: VetoableListDecorator doesn't accept its own sublists for bulk operations

2025-02-25 Thread Michael Strauß
On Wed, 15 Jan 2025 00:32:37 GMT, Michael Strauß wrote: > Passing a `VetoableListDecorator.subList()` to any of its bulk operations > (`addAll`, `setAll`, `removeAll`, `retainAll`) throws > `ConcurrentModificationException`. The reason is that the > `VetoableListDecorator.modCount` field is in

Re: RFR: 8349091: Charts: exception initializing in a background thread [v2]

2025-02-25 Thread Andy Goryachev
On Sat, 22 Feb 2025 15:30:24 GMT, Kevin Rushforth wrote: >> good question! this code exercises both remove and add code paths. > > Maybe add a comment then? added a class-level comment. - PR Review Comment: https://git.openjdk.org/jfx/pull/1697#discussion_r1970248044

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children"

2025-02-25 Thread Andy Goryachev
On Tue, 14 Jan 2025 00:55:36 GMT, Michael Strauß wrote: > The `VetoableListDecorator` class does not override the default > implementation of `List.sort()`. The default implementation copies the > elements into an array, sorts the array, and then calls `List.set()` in a > loop to sort the List

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children"

2025-02-25 Thread Kevin Rushforth
On Tue, 14 Jan 2025 00:55:36 GMT, Michael Strauß wrote: > The `VetoableListDecorator` class does not override the default > implementation of `List.sort()`. The default implementation copies the > elements into an array, sorts the array, and then calls `List.set()` in a > loop to sort the List

Re: RFR: 8233179: VetoableListDecorator#sort throws IllegalArgumentException "duplicate children"

2025-02-25 Thread Kevin Rushforth
On Tue, 14 Jan 2025 00:55:36 GMT, Michael Strauß wrote: > The `VetoableListDecorator` class does not override the default > implementation of `List.sort()`. The default implementation copies the > elements into an array, sorts the array, and then calls `List.set()` in a > loop to sort the List

Re: RFR: 8347753: VetoableListDecorator doesn't accept its own sublists for bulk operations [v2]

2025-02-25 Thread Kevin Rushforth
On Mon, 27 Jan 2025 18:34:30 GMT, Michael Strauß wrote: >> Passing a `VetoableListDecorator.subList()` to any of its bulk operations >> (`addAll`, `setAll`, `removeAll`, `retainAll`) throws >> `ConcurrentModificationException`. The reason is that the >> `VetoableListDecorator.modCount` field i

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-25 Thread Oliver Schmidtmer
On Tue, 25 Feb 2025 14:36:59 GMT, Kevin Rushforth wrote: >> Oliver Schmidtmer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> check both UTF16 bytes > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinSystemClipboard.java >

Re: RFR: 8281384: Random chars on paste from Windows clipboard [v2]

2025-02-25 Thread Oliver Schmidtmer
> Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text field, > including the NUL terminator and the remaining chars.

Re: RFR: 8281384: Random chars on paste from Windows clipboard

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 14:36:38 GMT, Kevin Rushforth wrote: >> Windows programs may reuse a clipboard buffer that is larger than the new >> content. In this case de NUL terminator is not at the end of the buffer, but >> within it. >> The current implementation copys the whole buffer into a text f

Re: RFR: 8281384: Random chars on paste from Windows clipboard

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 13:25:07 GMT, Oliver Schmidtmer wrote: > Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text fi

Re: RFR: 8281384: Random chars on paste from Windows clipboard

2025-02-25 Thread Kevin Rushforth
On Tue, 25 Feb 2025 13:25:07 GMT, Oliver Schmidtmer wrote: > Windows programs may reuse a clipboard buffer that is larger than the new > content. In this case de NUL terminator is not at the end of the buffer, but > within it. > The current implementation copys the whole buffer into a text fi

RFR: 8281384: Random chars on paste from Windows clipboard

2025-02-25 Thread Oliver Schmidtmer
Windows programs may reuse a clipboard buffer that is larger than the new content. In this case de NUL terminator is not at the end of the buffer, but within it. The current implementation copys the whole buffer into a text field, including the NUL terminator and the remaining chars. The JIRA

[jfx24u] Integrated: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6

2025-02-25 Thread Jay Bhaskar
On Tue, 25 Feb 2025 09:51:22 GMT, Jay Bhaskar wrote: > clean backport to jfx24u, the update is for cherry pick Webkitgtk-2.46.6 > backport from mainline. This pull request has now been integrated. Changeset: cdd4f2fd Author:Jay Bhaskar URL: https://git.openjdk.org/jfx24u/commit/cdd

[jfx24u] RFR: 8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6

2025-02-25 Thread Jay Bhaskar
clean backport to jfx24u, the update is for cherry pick Webkitgtk-2.46.6 backport from mainline. - Commit messages: - Backport f38ab33b296de7b0bf5b306e4803de8c686e2a83 Changes: https://git.openjdk.org/jfx24u/pull/9/files Webrev: https://webrevs.openjdk.org/?repo=jfx24u&pr=9&range

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false

2025-02-25 Thread Dirk Lemmermann
Thank you for detecting and fixing this issue guys. I have spent many days / weeks chasing issues related to this issue. It often came up with my custom controls and I was always assuming that it is me making a mistake. I never even considered that this might be a bug in the layout code. Dirk