On Tue, 25 Feb 2025 16:21:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> factor out setAll implementation > > modules/javafx.base/src/main/java/com/sun/javafx/collections/VetoableListDecorator.java > line 115: > >> 113: modCount--; >> 114: throw e; >> 115: } > > Could this be replaced by `setAll(sortedList)`? That would incur another unnecessary copy of the list. I've factored out the common `setAllImpl` instead to prevent these copies. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1674#discussion_r1970352937
