On Tue, 25 Feb 2025 17:03:17 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> ## Added Missing Controls >> >> ButtonBar >> ProgressIndicator >> Separator >> Slider, >> >> ## Added Node Classes >> >> AnchorPane >> AmbientLight >> Arc >> BorderPane >> Box >> Circle >> CubicCurve >> Cylinder >> DialogPane >> DirectionalLight >> Ellipse >> FlowPane >> GridPane >> Group >> HBox >> ImageView >> Line >> MediaView >> MeshView >> Pane >> ParallelCamera >> Path >> PerspectiveCamera >> PointLight >> Polygon >> Polyline >> QuadCurve >> Rectangle >> Region >> Sphere >> StackPane >> SVGPath >> TilePane >> VBox >> >> >> ## Miscellaneous >> >> - minor improvements >> - remove tests that execute show() in non-fx threads per >> [JDK-8350048](https://bugs.openjdk.org/browse/JDK-8350048) >> >> >> >> ## Not Included Due to Threading Limitations >> >> HTMLEditor >> MenuBar >> SwingNode >> WebView >> >> ## Note to the Reviewers >> >> To avoid merge conflicts, the preferred order of integrations: >> >> #1697 >> #1713 >> #1717 > > tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java > line 227: > >> 225: public class NodeInitializationStressTest extends RobotTestBase { >> 226: /* debugging aid: set this flag to true and comment out >> assumeFalse(SKIP_TEST) to run specific test(s). */ >> 227: private static final boolean SKIP_TEST = false; > > Maybe it's time to remove this flag? Does Eclipse not provide a way to run a > single test? Yes, the problem in Eclipse is that it creates a launch configuration which is always incorrect (the dependencies must be modified for each new configuration). I'd like to keep it. There is very little overhead. > tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java > line 656: > >> 654: >> 655: @Test >> 656: public void imageView() { > > You mentioned that there was a problem with modifying a writable image on a > background thread. Similarly, there might be a problem loading animated GIF > images on a background thread. Is there a bug filed? I guess it works as designed, see ImageView:254 Toolkit.getImageAccessor().getImageProperty(_image).addListener(platformImageChangeListener.getWeakListener()); so an animated GIF would most likely be off limits from a background thread as well. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1713#discussion_r1970399115 PR Review Comment: https://git.openjdk.org/jfx/pull/1713#discussion_r1970404189
