On Tue, 25 Feb 2025 17:26:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> ## Added Missing Controls
>> 
>> ButtonBar
>> ProgressIndicator
>> Separator
>> Slider,
>> 
>> ## Added Node Classes
>> 
>> AnchorPane
>> AmbientLight
>> Arc
>> BorderPane
>> Box
>> Circle
>> CubicCurve
>> Cylinder
>> DialogPane
>> DirectionalLight
>> Ellipse
>> FlowPane
>> GridPane
>> Group
>> HBox
>> ImageView
>> Line
>> MediaView
>> MeshView
>> Pane
>> ParallelCamera
>> Path
>> PerspectiveCamera
>> PointLight
>> Polygon
>> Polyline
>> QuadCurve
>> Rectangle
>> Region
>> Sphere
>> StackPane
>> SVGPath
>> TilePane
>> VBox
>> 
>> 
>> ## Miscellaneous
>> 
>> - minor improvements
>> - remove tests that execute show() in non-fx threads per 
>> [JDK-8350048](https://bugs.openjdk.org/browse/JDK-8350048)
>> 
>> 
>> 
>> ## Not Included Due to Threading Limitations
>> 
>> HTMLEditor
>> MenuBar
>> SwingNode
>> WebView
>> 
>> ## Note to the Reviewers
>> 
>> To avoid merge conflicts, the preferred order of integrations:
>> 
>> #1697 
>> #1713 
>> #1717
>
> tests/system/src/test/java/test/robot/javafx/scene/NodeInitializationStressTest.java
>  line 737:
> 
>> 735:             c.setFitHeight(nextDouble(200));
>> 736:             c.setFitWidth(nextDouble(200));
>> 737:             //c.setMediaPlayer(new MediaPlayer(new 
>> Media("no-data-url-support")));
> 
> Would it be useful to load a media file? If so, you could use the default 
> media file that Ensemble uses.

I don't think we want to download media from an URL as part of this test, and 
data URLs are not supported by Media (and it will be too long anyway).

I think we can classify this under rubric "one can only create a JavaFX object 
in a background thread, but not utilize it".

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1713#discussion_r1970413210

Reply via email to