On Fri, 14 Feb 2025 17:38:48 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/resources/com/sun/glass/ui/gtk/WindowDecorationGnome.css
>> line 125:
>>
>>> 123:
>>> 124: .close-button > .glyph {
>>> 125: -fx-shape: "m 8.1464844,8.1464844 a 0.5,0.5 0 0 0 0,0.7070312 L
>>> 11.2
On Fri, 14 Feb 2025 15:43:38 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - typo
>> - update copyright headers
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java l
> Implementation of
> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
> and `EXTENDED_UTILITY` stage style.
Michael Strauß has updated the pull request incrementally with one additional
commit since the last revision:
minify button glyphs
-
Changes:
On Wed, 12 Feb 2025 19:07:19 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Animation was started in the background thread, causing concurrent access.
>
> ## Solution
>
> Disable animation if not the fx app thread.
This pull request has now been integrated.
Changeset: 01059d4f
Author:And
On Thu, 6 Feb 2025 20:43:54 GMT, Andy Goryachev wrote:
> ## Root Cause
> Animation gets started in a background thread, which causes the animation
> handler to run in the FX application thread, thus creating simultaneous
> access to the control's fields (list of children in this case).
>
> ##
On Fri, 14 Feb 2025 18:20:53 GMT, Andy Goryachev wrote:
>> ## Root Cause
>>
>> Animation was started in the background thread, causing concurrent access.
>>
>> ## Solution
>>
>> Disable animation if not the fx app thread.
>
> Andy Goryachev has updated the pull request with a new target base d
On Fri, 14 Feb 2025 18:26:31 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Wed, 12 Feb 2025 19:45:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> Focus is being requested in show(), even a background thread.
>
> ## Solution
>
> Do not request focus if in a background thread.
This pull request has been closed without being integrated.
-
PR: https:/
On Wed, 12 Feb 2025 20:15:03 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> The ContextMenu (PopupWindow) cannot be shown in a background thread.
>
> ## Solution
>
> Bail out of `show()` if in a background thread.
This pull request has been closed without being integrated.
-
PR:
On Fri, 14 Feb 2025 18:20:53 GMT, Andy Goryachev wrote:
>> ## Root Cause
>>
>> Animation was started in the background thread, causing concurrent access.
>>
>> ## Solution
>>
>> Disable animation if not the fx app thread.
>
> Andy Goryachev has updated the pull request with a new target base d
On Fri, 14 Feb 2025 18:26:31 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
> ## Root Cause
> Animation gets started in a background thread, which causes the animation
> handler to run in the FX application thread, thus creating simultaneous
> access to the control's fields (list of children in this case).
>
> ## Solution
> Postpone the animation unless running in the F
> ## Root Cause
>
> Animation was started in the background thread, causing concurrent access.
>
> ## Solution
>
> Disable animation if not the fx app thread.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 27 commits
On Fri, 14 Feb 2025 18:18:59 GMT, Kevin Rushforth wrote:
> Can you merge master so this will be realized?
done.
-
PR Comment: https://git.openjdk.org/jfx/pull/1698#issuecomment-2659998222
On Tue, 11 Feb 2025 23:33:42 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Thu, 13 Feb 2025 18:32:58 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1442:
>>
>>> 1440: // of this node, since visibility affects
>>> bounds of the
>>> 1441: // parent node
>>> 1442:
On Tue, 11 Feb 2025 21:16:32 GMT, Andy Goryachev wrote:
> ## Root Cause
>
> An event handler was installed on the root property without removing it when
> the root changes.
>
> ## Solution
>
> Replaced the weak parts with a change listener to the root property to ensure
> correct handling of
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote:
>> This PR contains a definition of preview features for JavaFX, as well as a
>> helper class to verify that an application has opted into preview features.
>
> Michael Strauß has updated the pull request incrementally with four
> additiona
On Thu, 6 Feb 2025 23:20:30 GMT, Andy Goryachev wrote:
> ## Root Cause
> Animation gets started in a background thread, which causes the animation
> handler to run in the FX application thread, thus creating simultaneous
> access to the control's fields (list of children in this case).
>
> ##
On Fri, 14 Feb 2025 16:23:58 GMT, Kevin Rushforth wrote:
>> Although, having said that, the purpose of the cleanup is to clean up after
>> the animation. So a better fix might be to put the entire if-else inside an
>> `if (Platform.isFxApplicationThread())` test.
>
> Actually, no. It also calls
On Tue, 5 Nov 2024 19:10:01 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> stylistic changes
>
> modules/javafx.graphics/src/main/resources/com/sun/glass/ui/gtk/WindowDecorationGnome.css
> l
On Thu, 13 Feb 2025 19:10:15 GMT, Michael Strauß wrote:
>> Implementation of
>> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
>> and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with two additional
> commits since
On Sun, 9 Feb 2025 19:10:49 GMT, Thiago Milczarek Sayao
wrote:
> The issue was with the view's position, specifically the content's X and Y
> coordinates relative to the window, including its decorations. When in
> fullscreen mode, the window remains decorated, but the decorations are
> hidde
On Fri, 7 Feb 2025 18:42:01 GMT, Andy Goryachev wrote:
>> ## Root Cause
>> Animation gets started in a background thread, which causes the animation
>> handler to run in the FX application thread, thus creating simultaneous
>> access to the control's fields (list of children in this case).
>>
On Fri, 14 Feb 2025 16:20:33 GMT, Kevin Rushforth wrote:
>> If you mean two threads accessing this same TabPaneSkin instance, then
>> that's not a valid case. JavaFX objects are not thread-safe when accessed
>> from multiple threads. This bug (and the other related bugs fixed or under
>> revie
On Fri, 14 Feb 2025 16:12:27 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java
>> line 523:
>>
>>> 521: };
>>> 522:
>>> 523: if (Platform.isFxApplicationThread() &&
>>> (closeTabAnimation.get() == Ta
On Thu, 13 Feb 2025 12:45:20 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> comm
On Fri, 14 Feb 2025 03:43:25 GMT, Jay Bhaskar wrote:
> Some newly added, unimplemented functions in FileSystemJava.cpp during the
> WebKit upgrade to version 620.1 should include print statements to indicate
> at runtime when these functions are invoked.
LGTM. Please wait 24 hours in case ther
On Thu, 6 Feb 2025 13:18:35 GMT, Marius Hanl wrote:
>> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup
>> for the `fixedCellSize` instead of adding listener just to update
>> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be
>> also just
On Thu, 13 Feb 2025 18:51:22 GMT, Michael Strauß wrote:
> layout containers never visually clip their contents
see `PaginationSkin.install()`
Although in Pane:94:
* Pane does not clip its content by default, so it is possible that children's
* bounds may extend outside its own bounds, eithe
On Fri, 14 Feb 2025 10:19:13 GMT, Jay Bhaskar wrote:
> A clean backport to jfx24u. The update is related to webkit upgrae up to
> 2.46.5.
This pull request has now been integrated.
Changeset: 33907ec4
Author:Jay Bhaskar
URL:
https://git.openjdk.org/jfx24u/commit/33907ec4daa6c9d79ca
On Fri, 14 Feb 2025 14:08:34 GMT, Thiago Milczarek Sayao
wrote:
> Does the name `EXTENDED` accurately reflect its functionality? I have a
> feeling there's a better name for it.
Here are some alternatives:
* `FULL_SIZE`, like in AppKit's `NSWindowStyleMaskFullSizeContentView`
* `COMBINED`, mea
On Thu, 13 Feb 2025 19:10:15 GMT, Michael Strauß wrote:
>> Implementation of
>> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09)
>> and `EXTENDED_UTILITY` stage style.
>
> Michael Strauß has updated the pull request incrementally with two additional
> commits since
On Fri, 14 Feb 2025 13:31:04 GMT, Thiago Milczarek Sayao
wrote:
>> The issue was with the view's position, specifically the content's X and Y
>> coordinates relative to the window, including its decorations. When in
>> fullscreen mode, the window remains decorated, but the decorations are
>>
> The issue was with the view's position, specifically the content's X and Y
> coordinates relative to the window, including its decorations. When in
> fullscreen mode, the window remains decorated, but the decorations are
> hidden. As a result, the content's position needs to be recalculated to
Hi all,
This pull request contains a backport of commit
[53fe8f1a](https://github.com/openjdk/jfx/commit/53fe8f1a03f7e5c386a3341315834751c17b8514)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Alexander Zvegintsev on 14 Feb 2025
and
On Thu, 13 Feb 2025 11:54:01 GMT, Alexander Zvegintsev
wrote:
> This changeset updates the pipewire headers to the 1.3.81, and it is the same
> as for the [OpenJDK](https://github.com/openjdk/jdk/pull/23426)
>
> It contains the minimum set of required header files needed to build the JFX.
>
On Tue, 11 Feb 2025 11:51:26 GMT, Thiago Milczarek Sayao
wrote:
>> The issue was with the view's position, specifically the content's X and Y
>> coordinates relative to the window, including its decorations. When in
>> fullscreen mode, the window remains decorated, but the decorations are
>>
A clean backport to jfx24u. The update is related to webkit upgrae up to 2.46.5.
-
Commit messages:
- Backport 1e6915738d654e6cf7a547e47b8b020117db6bc3
Changes: https://git.openjdk.org/jfx24u/pull/4/files
Webrev: Webrev is not available because diff is too large
Issue: https://b
39 matches
Mail list logo
