On Fri, 14 Feb 2025 13:31:04 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
>> The issue was with the view's position, specifically the content's X and Y >> coordinates relative to the window, including its decorations. When in >> fullscreen mode, the window remains decorated, but the decorations are >> hidden. As a result, the content's position needs to be recalculated to >> account for the window's adjusted layout. >> >> It's not specific to i3. >> >> I used `gdk_window_get_root_origin` because GTK provides a more robust >> mechanism to determine the value, even in cases where _NET_FRAME_EXTENTS is >> not supported by the window manager. > > Thiago Milczarek Sayao has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains five > additional commits since the last revision: > > - Merge branch 'master' into 8348095 > - Clarify the meaning of x and y. > - Clarify the meaning of view_x and view_y. > - Forgot debug print > - 8348095: [Linux] Menu shows up in wrong position when using i3 windows > manager in full screen mode Everything works fine now. LGTM ------------- Marked as reviewed by lkostyra (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1702#pullrequestreview-2617883340
