On Tue, 5 Nov 2024 19:10:01 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> stylistic changes
>
> modules/javafx.graphics/src/main/resources/com/sun/glass/ui/gtk/WindowDecorationGnome.css
> line 125:
>
>> 123:
>> 124: .close-button > .glyph {
>> 125: -fx-shape: "m 8.1464844,8.1464844 a 0.5,0.5 0 0 0 0,0.7070312 L
>> 11.292969,12 8.1464844,15.146484 a 0.5,0.5 0 0 0 0,0.707032 0.5,0.5 0 0 0
>> 0.7070312,0 L 12,12.707031 l 3.146484,3.146485 a 0.5,0.5 0 0 0 0.707032,0
>> 0.5,0.5 0 0 0 0,-0.707032 L 12.707031,12 15.853516,8.8535156 a 0.5,0.5 0 0 0
>> 0,-0.7070312 0.5,0.5 0 0 0 -0.707032,0 L 12,11.292969 8.8535156,8.1464844 a
>> 0.5,0.5 0 0 0 -0.7070312,0 z";
>
> minor: we could probably minimize the path by rounding to 2 or 3 decimal
> points
> (same comment for all .css changes)
any response on this?
> modules/javafx.graphics/src/main/resources/com/sun/glass/ui/win/WindowDecoration.css
> line 107:
>
>> 105:
>> 106: .maximize-button.restore > .glyph {
>> 107: -fx-shape: "m 7.6491699,2.5192871 q 0,-0.3444824
>> -0.1369629,-0.6495361 Q 7.3752441,1.5646973 7.1407471,1.338501
>> 6.90625,1.1123047 6.5970459,0.98156738 6.2878418,0.85083008
>> 5.9475098,0.85083008 H 1.7722168 Q 1.838623,0.65991211 1.9589844,0.50219727
>> 2.0793457,0.34448242 2.2370605,0.23242188 2.3947754,0.12036133
>> 2.5836182,0.06018066 2.7724609,0 2.9758301,0 H 5.9475098 Q 6.4746094,0
>> 6.9394531,0.20129395 7.4042969,0.40258789 7.7508545,0.74707031
>> 8.0974121,1.0915527 8.2987061,1.5563965 8.5,2.0212402 8.5,2.5483398 V
>> 5.5241699 Q 8.5,5.7275391 8.4398193,5.9163818 8.3796387,6.1052246
>> 8.2675781,6.2629395 8.1555176,6.4206543 7.9978027,6.5410156
>> 7.8400879,6.661377 7.6491699,6.7277832 Z M 1.253418,8.5 Q 1.0043945,8.5
>> 0.77612305,8.3983154 0.54785156,8.2966309 0.37561035,8.1243896
>> 0.20336914,7.9521484 0.10168457,7.723877 0,7.4956055 0,7.246582 V 2.9550781
>> Q 0,2.7019043 0.10168457,2.475708 0.20336914,2.2495117 0.37561035,2.0772705
>> 0.54785156,1.9050293 0.77404785,1.8033447 1.0002441,1.7016
602 1.253418,1.7016602 h 4.2915039 q 0.2531738,0 0.4814453,0.1016845
0.2282715,0.1016846 0.3984375,0.2718506 0.170166,0.170166 0.2718506,0.3984375
0.1016845,0.2282715 0.1016845,0.4814453 V 7.246582 q 0,0.2531739
-0.1016845,0.4793701 Q 6.5949707,7.9521484 6.4227295,8.1243896
6.2504883,8.2966309 6.024292,8.3983154 5.7980957,8.5 5.5449219,8.5 Z M
5.5241699,7.6491699 q 0.087158,0 0.1639405,-0.033203 0.076782,-0.033203
0.1369628,-0.091309 0.060181,-0.058105 0.093384,-0.1348877 0.033203,-0.076782
0.033203,-0.1639404 v -4.25 q 0,-0.087158 -0.033203,-0.1660156 Q
5.8852539,2.730957 5.8271484,2.6728516 5.769043,2.6147461 5.6901855,2.581543
5.6113281,2.5483398 5.5241699,2.5483398 h -4.25 q -0.087158,0
-0.1639404,0.033203 -0.076782,0.033203 -0.1348877,0.093384 -0.0581055,0.060181
-0.0913086,0.1369628 -0.0332031,0.076782 -0.0332031,0.1639405 v 4.25 q
0,0.087158 0.0332031,0.1639404 0.0332031,0.076782 0.0913086,0.1348877
0.0581055,0.058105 0.1348877,0.091309 0.076782,0.033203 0.1639404,0.033203 z"
;
>
> ... especially here
... response?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1956510916
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1956511237
