On Tue, 7 May 2024 19:53:57 GMT, Kevin Rushforth wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2]
>
> modules/javafx.media/src/main/java/com/
On Tue, 7 May 2024 20:39:13 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Tue, 7 May 2024 20:39:13 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Tue, 7 May 2024 20:39:13 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Fri, 26 Apr 2024 23:36:26 GMT, Alexander Matveev
wrote:
>> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming.
>> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR
>> for more details):
>> - MP2T streams with one H.264/AVC video track and elementary AAC
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp h
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp h
On Tue, 7 May 2024 19:25:53 GMT, Andy Goryachev wrote:
>> They just read the `os.name` with `System.getProperty("os.name") but that
>> only includes the Standard values.
>> https://github.com/junit-team/junit5/blob/db47616ab4ccf38ff63e8bff41050d5102c9ff15/junit-jupiter-api/src/main/java/org/juni
On Tue, 7 May 2024 19:13:02 GMT, Christoph wrote:
>>> EnabledOnOs
>>
>> thank you @Siedlerchr for this info.
>> I wonder what criteria are set for determining the OS value, and do they
>> match jfx ones?
>
> They just read the `os.name` with `System.getProperty("os.name") but that
> only inclu
On Tue, 7 May 2024 18:53:17 GMT, Andy Goryachev wrote:
>> Junit 5 has an EnabledOnOs annotation
>> https://junit.org/junit5/docs/5.2.0/api/org/junit/jupiter/api/condition/EnabledOnOs.html
>
>> EnabledOnOs
>
> thank you @Siedlerchr for this info.
> I wonder what criteria are set for determining
On Fri, 3 May 2024 14:45:24 GMT, John Hendrikx wrote:
> This PR provides a fix for the linked issue.
>
> The issue was that when an invalidation listener is removed, and the
> `ExpressionHelper` type changes from `Generic` to `SingleChange` that it
> would copy the current value of the `Generi
On Tue, 7 May 2024 18:47:04 GMT, Christoph wrote:
> EnabledOnOs
thank you @Siedlerchr for this info.
I wonder what criteria are set for determining the OS value, and do they match
jfx ones?
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592928523
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Tue, 7 May 2024 18:46:26 GMT, Oliver Kopp wrote:
>> We still want to use `assumeTrue` as the pattern (for flexibility), so the
>> question is whether there is a better place besides a method annotated with
>> `@BeforeAll` to put it (which also means duplicating the assumption in the
>> `@Af
On Tue, 7 May 2024 18:30:25 GMT, Kevin Rushforth wrote:
>> maybe
>> https://stackoverflow.com/questions/26115139/junit-ignore-or-skip-entire-test-class
>> ?
>
> We still want to use `assumeTrue` as the pattern (for flexibility), so the
> question is whether there is a better place besides a meth
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 16:39:47 GMT, Andy Goryachev wrote:
>> is there a good way to skip the whole file entirely, e.g. via junit
>> annotation?
>
> maybe
> https://stackoverflow.com/questions/26115139/junit-ignore-or-skip-entire-test-class
> ?
We still want to use `assumeTrue` as the pattern (for
On Wed, 13 Mar 2024 08:55:14 GMT, Florian Kirmaier
wrote:
>> @FlorianKirmaier I still think this would be a good addition. I believe
>> there is only one open question (from Marius) so it would be great if you
>> can answer that.
>
> @johanvos
> Great to see you would like to see it merged!
>
On Tue, 7 May 2024 09:44:08 GMT, eduardsdv wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Use viewport length as block increment
>
> In my opinion, this PR is now ready.
should the contributor in
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 14:18:29 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
> line 218:
>
>> 216:
On Tue, 7 May 2024 16:37:06 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java
>> line 56:
>>
>>> 54: @AfterAll
>>> 55: static void shutdown() {
>>> 56: Util.shutdown();
>>
>> This fails on Mac and Linux because the
On Tue, 7 May 2024 16:29:33 GMT, Kevin Rushforth wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Streamline WinTextRangeProviderTest
>>
>> Source:
>> https://github.com/openjdk/jfx/pull/1442#pullrequestreview-
On Mon, 6 May 2024 08:24:52 GMT, drmarmac wrote:
> This PR updates the javadoc for the SpinnerFactory wrap-around behavior
> introduced in #1431.
This pull request has now been integrated.
Changeset: 36e65e8b
Author:drmarmac <6900949+drmar...@users.noreply.github.com>
Committer: Kevin Rush
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compar
On Tue, 7 May 2024 15:39:29 GMT, Andy Goryachev wrote:
>> I guess that's because IntelliJ doesn't process the javafx properties.
>
> that's why _some say_ eclipse is better:
>
>  in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Tue, 7 May 2024 15:46:18 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Tue, 7 May 2024 14:18:44 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
> line 446:
>
>> 444:
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property is being set by the code which computes the actual text
> string to be displayed (and which inserts t
On Tue, 7 May 2024 15:27:55 GMT, Kevin Rushforth wrote:
>> Updated. I checked this variant with IntelliJ: While I can follow the link,
>> it doesn't show the wrapAround field's javadoc, just the
>> wrapAroundProperty's javadoc which is empty.
>
> I guess that's because IntelliJ doesn't process
Dear Michael:
Thank you for a thoughtful feedback!
You are correct - the new proposal is a variation of the old one, with
modifications intended to address the earlier use cases identified by you and
John, namely the event handler priority and the stateless behaviors.
The reason I propose to s
On Tue, 7 May 2024 15:28:56 GMT, Karthik P K wrote:
>> Can you please clarify your question? I don't understand.
>
> I wanted to check, In this line: "or with the ellipsis string inserted into
> strategic place(s) if it does not.", can we add reference to ellipsisString
> parameter similar to
On Tue, 7 May 2024 14:56:57 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
>> line 218:
>>
>>> 216: * Computes the actual text to be shown in the Labeled with the
>>> text wrapping disabled:
>>> 217: * unmodified if it
On Tue, 7 May 2024 06:11:59 GMT, drmarmac wrote:
>> That one should work everywhere, since it is equivalent. Worth
>> double-checking, though.
>
> Updated. I checked this variant with IntelliJ: While I can follow the link,
> it doesn't show the wrapAround field's javadoc, just the wrapAroundPro
On Tue, 7 May 2024 06:09:07 GMT, drmarmac wrote:
>> This PR updates the javadoc for the SpinnerFactory wrap-around behavior
>> introduced in #1431.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last revision:
>
> javaDoc: Qualify property link
On Tue, 7 May 2024 06:09:07 GMT, drmarmac wrote:
>> This PR updates the javadoc for the SpinnerFactory wrap-around behavior
>> introduced in #1431.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last revision:
>
> javaDoc: Qualify property link
On Mon, 6 May 2024 15:23:20 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Tue, 7 May 2024 09:02:49 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
> line 236:
>
>> 2
On Tue, 7 May 2024 10:10:23 GMT, Karthik P K wrote:
> The `ComboBox` value was not set to previously selected value in the item
> list change listener when `setAll` method is used to change the item list.
> Fixed the issue by restoring the selection in this case.
>
> Added a unit test to valid
The `ComboBox` value was not set to previously selected value in the item list
change listener when `setAll` method is used to change the item list. Fixed the
issue by restoring the selection in this case.
Added a unit test to validate the fix
-
Commit messages:
- Fix item selecti
On Mon, 6 May 2024 18:05:06 GMT, Andy Goryachev wrote:
>> I agree with you, at least with scrolling when clicking on the scrollbar
>> track.
>> I would like to change the amount of scroll pixels to the viewport length.
>>
>> PageUp/PageDown not only scrolls the view, but also moves the
>> sel
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
> As seen in the unit test of the PR, when we click on the area above/below the
> scrollbar the position jumps - but the jump is now not always consistent.
> In the current version on the last cell - the UI always jumps to the top. In
> the other cases, the assumed default cell height is used.
>
On Mon, 6 May 2024 15:23:20 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
Hi Andy!
The updated proposal seems to be a slight refinement of the original
proposal, and I think most of the points raised in the previous
discussion still stand.
As it is, I still think that this is an exceptionally large API
surface for what the feature can actually bring to the table. It's
On Fri, 3 May 2024 14:45:24 GMT, John Hendrikx wrote:
> This PR provides a fix for the linked issue.
>
> The issue was that when an invalidation listener is removed, and the
> `ExpressionHelper` type changes from `Generic` to `SingleChange` that it
> would copy the current value of the `Generi
49 matches
Mail list logo
