On Tue, 7 May 2024 18:30:25 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> maybe >> https://stackoverflow.com/questions/26115139/junit-ignore-or-skip-entire-test-class >> ? > > We still want to use `assumeTrue` as the pattern (for flexibility), so the > question is whether there is a better place besides a method annotated with > `@BeforeAll` to put it (which also means duplicating the assumption in the > `@AfterAll` method). I'm not aware of one, but maybe someone else is? My source: https://stackoverflow.com/q/30112317/873282, but I did totally forget about `@AfterAll`. I was assuming that that would also have been skipped if the `@BeforeAll` was skipped. 🙈 Think, for users coming from JUnit4, it is better to put the statements in each test method, even though not executed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592921618