On Tue, 7 May 2024 14:18:44 GMT, Karthik P K <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
> line 446:
>
>> 444: * Computes the actual text to be shown in the Labeled with the
>> text wrapping enabled:
>> 445: * unmodified if it fits into available area,
>> 446: * or with the ellipsis string inserted into strategic place(s) if
>> it does not.
>
> Similar to previous comment. ellipsis string can be referenced similar to
> textTruncated?
oh, you want to use `{@code ellipsisString}` instead of the words "ellipsis
string", got it.
I thought it was clear enough, but yes, can be easily changed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1592703489
