On Tue, 7 May 2024 16:29:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Streamline WinTextRangeProviderTest >> >> Source: >> https://github.com/openjdk/jfx/pull/1442#pullrequestreview-2035329983 > > tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java > line 56: > >> 54: @AfterAll >> 55: static void shutdown() { >> 56: Util.shutdown(); > > This fails on Mac and Linux because the initialization (and consequently all > tests) are skipped, but the call to `Util.shutdown` is not skipped. You will > either need to also add `assumeTrue(PlatformUtil.isWindows());` here or else > move the `assumeTrue` to the test method. is there a good way to skip the whole file entirely, e.g. via junit annotation? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592779192
