Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115596/#review49818 --- I still feel it's a pixel too low, at lest the "Opened a docum

[Okular-devel] Review Request 115759: Fix for Bug 326207

2014-02-15 Thread Jaan Vajakas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/ --- Review request for Okular. Bugs: 326207 http://bugs.kde.org/show_bug.

[Okular-devel] [okular] [Bug 326207] Search algorithm finds a result for "valuesas" when the real text is "values as"

2014-02-15 Thread Jaan Vajakas
https://bugs.kde.org/show_bug.cgi?id=326207 Jaan Vajakas changed: What|Removed |Added CC||jaanvaja...@hot.ee --- Comment #2 from Jaan Vaja

Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

2014-02-15 Thread Luigi Toscano
> On Feb. 15, 2014, 12:24 p.m., Albert Astals Cid wrote: > > I still feel it's a pixel too low, at lest the "Opened a document of 5 > > pages" message seems closer to the bottom line now than without the patch. > > If you'ree feeling i'm being too silly i can try to fix this thing myself :D Th

[Okular-devel] [okular] [Bug 326207] Search algorithm finds a result for "valuesas" when the real text is "values as"

2014-02-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326207 --- Comment #3 from Albert Astals Cid --- Did you assign that patch to the okular group? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@k

[Okular-devel] [okular] [Bug 326207] Search algorithm finds a result for "valuesas" when the real text is "values as"

2014-02-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=326207 --- Comment #4 from Albert Astals Cid --- Yes you did, ignore me :D -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.k

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review49827 --- You don't seem to be progressing much so i decided to do part

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

2014-02-15 Thread Michal Humpula
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 15, 2014, 2:47 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

2014-02-15 Thread Michal Humpula
> On Feb. 9, 2014, 12:26 a.m., Albert Astals Cid wrote: > > core/page.cpp, line 758 > > > > > > deleting null is fine, you don't need the if Thanks for review. Remembering what and why I done after three months

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review49831 --- core/textpage.cpp

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review49833 --- I'd say you have uploaded the wrong diff. - Albert Astals Cid

Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115596/#review49838 --- Ship it! Please commit to master (no need for 4.12 here, righ

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2014-02-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111681/#review49849 --- I'm going to hate myself for suggeting this but what about di

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

2014-02-15 Thread Michal Humpula
> On Feb. 15, 2014, 3:15 p.m., Albert Astals Cid wrote: > > I'd say you have uploaded the wrong diff. ahh, sorry, so lame. - Michal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

2014-02-15 Thread Michal Humpula
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 15, 2014, 7:28 p.m.) Review request for Okular. Repositor

Re: [Okular-devel] Review Request 111681: TextDocumentGenerator: Use black as default text color

2014-02-15 Thread Christoph Feck
> On Feb. 15, 2014, 5:39 p.m., Albert Astals Cid wrote: > > I'm going to hate myself for suggeting this but what about > > > > diff --git a/generators/epub/converter.cpp b/generators/epub/converter.cpp > > index 394d852..cea74f7 100644 > > --- a/generators/epub/converter.cpp > > +++ b/generators

Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

2014-02-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115596/#review49885 --- This review has been submitted with commit 480df58d689a343853

Re: [Okular-devel] Review Request 115596: PageViewMessage - support for long messages

2014-02-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115596/ --- (Updated Feb. 15, 2014, 10:42 p.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 115759: Fix for Bug 326207

2014-02-15 Thread Jaan Vajakas
> On Feb. 15, 2014, 3:13 p.m., Albert Astals Cid wrote: > > core/textpage.cpp, line 790 > > > > > > why this change? As I wrote, the reason is that I think it is not good that layout analysis depends on the use

[Okular-devel] [okular] [Bug 198609] print uses always landscape instead of portrait

2014-02-15 Thread CDL
https://bugs.kde.org/show_bug.cgi?id=198609 CDL changed: What|Removed |Added CC||cdlpub...@centurylink.net --- Comment #10 from CDL --- D

[Okular-devel] [okular] [Bug 198609] print uses always landscape instead of portrait

2014-02-15 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=198609 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #11 from L

[Okular-devel] [okular] [Bug 326605] Inverse seach with kile doesn't work properly with the new Ubuntu

2014-02-15 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=326605 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #15 from L

[Okular-devel] [okular] [Bug 198609] print uses always landscape instead of portrait

2014-02-15 Thread CDL
https://bugs.kde.org/show_bug.cgi?id=198609 --- Comment #12 from CDL --- (In reply to comment #11) > Your version is quite old (and squeeze will be soon out of support). Could > you please try with a newer version? (however, please note that wheezy ships > with with Okular 0.14, while the versio

[Okular-devel] [okular] [Bug 331127] Attempting to open a recent file while another file is open causes Okular to crash

2014-02-15 Thread Alon Amster
https://bugs.kde.org/show_bug.cgi?id=331127 Alon Amster changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO