----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115759/#review49831 -----------------------------------------------------------
core/textpage.cpp <https://git.reviewboard.kde.org/r/115759/#comment35026> why this change? core/textpage.cpp <https://git.reviewboard.kde.org/r/115759/#comment35027> Can you explain this rationale? Also any reason you decided to write 2E3 instead 2000? tests/searchtest.cpp <https://git.reviewboard.kde.org/r/115759/#comment35025> please use kDebug and remove the iostream include - Albert Astals Cid On Feb. 15, 2014, 1:08 p.m., Jaan Vajakas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115759/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 1:08 p.m.) > > > Review request for Okular. > > > Bugs: 326207 > http://bugs.kde.org/show_bug.cgi?id=326207 > > > Repository: okular > > > Description > ------- > > Here is a patch to fix Bug 326207. It was a simple bug in the XY Cut layout > recognition code that made it too eager to see columns everywhere. I also > removed the dependence of the layout analysis algorithms on the display DPI > (introduced by the recently added feature of using KScreen) to make their > behavior more predictable and reproducible. I added tests for this bug and > also refactored SearchTest a little to use QVectors instead of bare arrays. > > > Diffs > ----- > > core/textpage.cpp a95f7c6 > tests/searchtest.cpp caceb6f > > Diff: https://git.reviewboard.kde.org/r/115759/diff/ > > > Testing > ------- > > added automatic tests and tested manually on some PDF files > > > Thanks, > > Jaan Vajakas > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
