----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115596/#review49885 -----------------------------------------------------------
This review has been submitted with commit 480df58d689a343853012540eb42d676cfd4a031 by Luigi Toscano to branch master. - Commit Hook On Feb. 12, 2014, 11:04 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115596/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 11:04 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > So far the messages displayed by PageViewMessage are quite short (grep for > "emit {error|warning|info}" in the code). The widget does not resize with > long messages, nor does it resize on viewparent resize. The patch fixes this > (with a bit of heuristic in the calculation of the boundary). > > Side note: I originally thought about porting it to KMessageWidget, but it > was more complex (with a different behavior in the end) that fixing it. On > the other side, PageViewTopMessage is a better candidate for being ported > (it's already used in layouts), but that's another story. > > > Diffs > ----- > > ui/pageviewutils.h bc77cc9 > ui/pageviewutils.cpp 3f99248 > > Diff: https://git.reviewboard.kde.org/r/115596/diff/ > > > Testing > ------- > > Tested normally and --reverse. I will attach a patch that allows to quickly > test it. > > > File Attachments > ---------------- > > Patch to test the change > > https://git.reviewboard.kde.org/media/uploaded/files/2014/02/09/1f06fce0-68d5-4cb1-bd45-a1727e7e3789__test_longmessage.diff > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
