> On Feb. 9, 2014, 12:26 a.m., Albert Astals Cid wrote: > > core/page.cpp, line 758 > > <https://git.reviewboard.kde.org/r/113986/diff/2/?file=215399#file215399line758> > > > > deleting null is fine, you don't need the if
Thanks for review. Remembering what and why I done after three months was a challenge:) - Michal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review49312 ----------------------------------------------------------- On Feb. 15, 2014, 2:47 p.m., Michal Humpula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/113986/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 2:47 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > ------- > > First shot for multiple tiles managers way. Let's face it -- it's nasty. But > the compiled okular is displaying my testing pdf without crashing, so at > least that. > > It's straighforward implementation. Every single place, where there were call > for (or with) TilesManager, now has a DocumentObserver as companion. The > m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, > TilesManager>. > > It's adding more code then I expected, but I think that now, when every > request can be back-supported by TilesManager, all the request can now be > served trought them and not by that direct Pixmap cache in Document. So with > that, it would actually be more deletion (imho). > > > Diffs > ----- > > CMakeLists.txt 217337f > conf/okular.kcfg deabd07 > ui/magnifierview.h PRE-CREATION > ui/magnifierview.cpp PRE-CREATION > ui/pageview.h 9c15af6 > ui/pageview.cpp 65967bf > > Diff: https://git.reviewboard.kde.org/r/113986/diff/ > > > Testing > ------- > > > Thanks, > > Michal Humpula > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
