Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485071664 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485071016 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485070192 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485069325 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485069325 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485068520 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067542 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067542 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485067235 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485066414 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485066347 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCom

Re: [PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
mdedetrich commented on code in PR #1112: URL: https://github.com/apache/incubator-pekko/pull/1112#discussion_r1485065506 ## cluster/src/main/scala/org/apache/pekko/cluster/SeedNodeProcess.scala: ## @@ -57,8 +57,10 @@ private[cluster] abstract class SeedNodeProcess(joinConfigCo

[PR] add default for pekko.cluster.akka.version [incubator-pekko]

2024-02-10 Thread via GitHub
pjfanning opened a new pull request, #1112: URL: https://github.com/apache/incubator-pekko/pull/1112 This property is only needed if you have pekko.remote.accept-protocol-names set up to include "akka". This is the case in the test config for pekko-remote and we get a lot of logging about p