[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

sashapolo commented on code in PR #2239: URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1244861676 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeImpl.java: ## @@ -119,48 +146,81 @@ public void updateSafeTime(Hyb

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2255: IGNITE-19120 Raft client should get leader metadata along while getting leader itself

vldpyatkov commented on code in PR #2255: URL: https://github.com/apache/ignite-3/pull/2255#discussion_r1244861785 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -1739,6 +1742,53 @@ public void handleReadIndexRequest(final ReadIndexRequest

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2255: IGNITE-19120 Raft client should get leader metadata along while getting leader itself

vldpyatkov commented on code in PR #2255: URL: https://github.com/apache/ignite-3/pull/2255#discussion_r1244864880 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -347,6 +356,83 @@ public void tes

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2255: IGNITE-19120 Raft client should get leader metadata along while getting leader itself

vldpyatkov commented on code in PR #2255: URL: https://github.com/apache/ignite-3/pull/2255#discussion_r1244866910 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -362,6 +448,22 @@ private String r

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

rpuch commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244868161 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -284,4 +286,24 @@ void testMetaStora

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244872366 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -128,75 +131,94 @@ public void notifyWatches(List updat

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2255: IGNITE-19120 Raft client should get leader metadata along while getting leader itself

vldpyatkov commented on code in PR #2255: URL: https://github.com/apache/ignite-3/pull/2255#discussion_r1244873078 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -362,6 +448,22 @@ private String r

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

sashapolo commented on code in PR #2239: URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1244879629 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/time/ClusterTimeTest.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Sof

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244882338 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -754,7 +754,30 @@ public CompletableFuture start(Path configPath) {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244882963 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -128,75 +131,94 @@ public void notifyWatches(List updat

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244884100 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -158,7 +158,7 @@ private static CompletableFuture noti

[GitHub] [ignite] vshipb opened a new pull request, #10811: IGNITE-19753

vshipb opened a new pull request, #10811: URL: https://github.com/apache/ignite/pull/10811 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The

[GitHub] [ignite] nizhikov merged pull request #10811: IGNITE-19753

nizhikov merged PR #10811: URL: https://github.com/apache/ignite/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244912561 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -690,7 +689,7 @@ public void closeSession() {

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

ibessonov commented on code in PR #2239: URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1244913159 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -137,66 +144,123 @@ public MetaStorageManagerImpl

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10797: IGNITE-19753 Move task classes to commands

sonarcloud[bot] commented on PR #10797: URL: https://github.com/apache/ignite/pull/10797#issuecomment-1611038128 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #2239: IGNITE-19199 Propagate safe time when Meta Storage is idle

sashapolo commented on code in PR #2239: URL: https://github.com/apache/ignite-3/pull/2239#discussion_r1244920522 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java: ## @@ -137,66 +144,123 @@ public MetaStorageManagerImpl

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1244920862 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -284,4 +286,24 @@ void testMetaS

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10811: IGNITE-19753

sonarcloud[bot] commented on PR #10811: URL: https://github.com/apache/ignite/pull/10811#issuecomment-1611054365 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

zstan commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1244990085 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -888,14 +903,6 @@ private CompletableFuture awaitFragmen

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

rpuch commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1245012622 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -987,6 +954,49 @@ public void init( cmgMgr.initCluster(metaStorageNodeName

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-1611162176 >The second problem is that it deals with literals only, while leaving dynamic params and columns references out of scope for some reason What makes you think so? Search bounds are built

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1245021456 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -987,6 +954,49 @@ public void init( cmgMgr.initCluster(metaStorageNode

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

rpuch commented on code in PR #2261: URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1245023160 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -987,6 +954,49 @@ public void init( cmgMgr.initCluster(metaStorageNodeName

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245027243 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -296,4 +364,67 @@ private ResultSetMetadata resultS

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245027243 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -296,4 +364,67 @@ private ResultSetMetadata resultS

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245027243 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -296,4 +364,67 @@ private ResultSetMetadata resultS

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1245052369 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -888,14 +903,6 @@ private CompletableFuture awaitFrag

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

korlov42 commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1244811505 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java: ## @@ -72,10 +84,13 @@ public class PrepareServiceImpl impl

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

korlov42 commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245059403 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -81,7 +80,7 @@ public class TestNode implements LifecycleAwa

[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

zstan commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1245063024 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java: ## @@ -107,7 +105,7 @@ public void testSessionExpiration() throws Exc

[GitHub] [ignite-3] zstan commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

zstan commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1245065903 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -888,14 +903,6 @@ private CompletableFuture awaitFragmen

[GitHub] [ignite-3] ibessonov merged pull request #2261: IGNITE-19851 Add MetaStorage revision update listeners and use instead of configuration revision update listeners

ibessonov merged PR #2261: URL: https://github.com/apache/ignite-3/pull/2261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

[GitHub] [ignite] anton-vinogradov merged pull request #10805: IGNITE-19845 IgniteTxLocalAdapter.sndTransformedVals field removal

anton-vinogradov merged PR #10805: URL: https://github.com/apache/ignite/pull/10805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite] anton-vinogradov merged pull request #10807: IGNITE-19847 IgniteTxAdapter.TxShadow removal

anton-vinogradov merged PR #10807: URL: https://github.com/apache/ignite/pull/10807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245087309 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -81,7 +80,7 @@ public class TestNode implements LifecycleA

[GitHub] [ignite-3] sk0x50 closed pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

sk0x50 closed pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error URL: https://github.com/apache/ignite-3/pull/2186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2186: IGNITE-19536 Added RecoverableException marker interface indicates recoverable error

sk0x50 commented on code in PR #2186: URL: https://github.com/apache/ignite-3/pull/2186#discussion_r1245097149 ## modules/api/src/main/java/org/apache/ignite/lang/RecoverableException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [ignite-3] lowka commented on pull request #2196: IGNITE-19615: Index is not used while performing SELECT over an indexed column.

lowka commented on PR #2196: URL: https://github.com/apache/ignite-3/pull/2196#issuecomment-1611269431 >I have reverted the changes to the state as were copied from ignite2. That would not work. Left all as it is - just renamed a method to `needToCastInIndex`. -- This is an automated m

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

AMashenkov commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245108429 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/CastExpressionTest.java: ## @@ -0,0 +1,440 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2214: IGNITE-19654: remove redundant planing timeout and use correct one.

AMashenkov commented on code in PR #2214: URL: https://github.com/apache/ignite-3/pull/2214#discussion_r1245119135 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItCommonApiTest.java: ## @@ -120,6 +122,27 @@ public void testSessionExpiration() thro

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1245139714 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionMapperUtil.java: ## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245143000 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -119,45 +120,38 @@ public static String toString(ByteSt

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245147975 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -119,45 +120,38 @@ public static String toString(ByteSt

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245151072 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -119,45 +120,38 @@ public static String toString(ByteSt

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245151091 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -119,45 +120,38 @@ public static String toString(ByteSt

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10806: IGNITE-19846 IgniteTxAdapter initial cleanup

sonarcloud[bot] commented on PR #10806: URL: https://github.com/apache/ignite/pull/10806#issuecomment-1611332430 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sk0x50 commented on a diff in pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 commented on code in PR #2225: URL: https://github.com/apache/ignite-3/pull/2225#discussion_r1242112542 ## modules/api/src/main/java/org/apache/ignite/lang/IgniteExceptionUtils.java: ## @@ -177,14 +177,15 @@ public static int extractCodeFrom(Throwable t) { return

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10806: IGNITE-19846 IgniteTxAdapter initial cleanup

sonarcloud[bot] commented on PR #10806: URL: https://github.com/apache/ignite/pull/10806#issuecomment-1611343139 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] sanpwc merged pull request #2253: IGNITE-19580 added restoring of zones state after restart

sanpwc merged PR #2253: URL: https://github.com/apache/ignite-3/pull/2253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] sk0x50 merged pull request #2224: IGNITE-17770 ItIgniteNodeRestartTest.testCfgGap is flaky

sk0x50 merged PR #2224: URL: https://github.com/apache/ignite-3/pull/2224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite] anton-vinogradov opened a new pull request, #10812: IGNITE-19872 IgniteTxLocalAdapter initial cleanup

anton-vinogradov opened a new pull request, #10812: URL: https://github.com/apache/ignite/pull/10812 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] AMashenkov merged pull request #2223: IGNITE-19668 Sql. Fix testLengthExpressionWithDynamicParameter

AMashenkov merged PR #2223: URL: https://github.com/apache/ignite-3/pull/2223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245189875 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -196,10 +198,42 @@ public static BigDecimal toBigDecima

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10812: IGNITE-19872 IgniteTxLocalAdapter initial cleanup

sonarcloud[bot] commented on PR #10812: URL: https://github.com/apache/ignite/pull/10812#issuecomment-1611394109 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1611394518 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245195829 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -196,10 +198,42 @@ public static BigDecimal toBigDecima

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245197413 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -196,10 +198,42 @@ public static BigDecimal toBigDecima

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10812: IGNITE-19872 IgniteTxLocalAdapter initial cleanup

sonarcloud[bot] commented on PR #10812: URL: https://github.com/apache/ignite/pull/10812#issuecomment-1611407219 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245208804 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -196,10 +198,42 @@ public static BigDecimal toBigDecima

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245210318 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -196,10 +198,42 @@ public static BigDecimal toBigDecima

[GitHub] [ignite] anton-vinogradov opened a new pull request, #10813: IGNITE-19873 GridNearTxLocal initial cleanup

anton-vinogradov opened a new pull request, #10813: URL: https://github.com/apache/ignite/pull/10813 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite-3] sk0x50 merged pull request #2225: IGNITE-19539 Added exception mapper utility

sk0x50 merged PR #2225: URL: https://github.com/apache/ignite-3/pull/2225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245226285 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -315,6 +335,252 @@ public void testDecimalLiteral() {

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245235582 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -209,6 +216,39 @@ public static BigDecimal toBigDecimal

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245254713 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java: ## @@ -209,6 +216,39 @@ public static BigDecimal toBigDecimal

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245255950 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -315,6 +335,252 @@ public void testDecimalLiteral() {

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245263682 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlDecimalLiteralTest.java: ## @@ -66,6 +70,32 @@ public void testValueAndType() {

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245269593 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlDecimalLiteralTest.java: ## @@ -66,6 +70,32 @@ public void testValueAndType() {

[GitHub] [ignite-3] lowka commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

lowka commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245270727 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlDecimalLiteralTest.java: ## @@ -66,6 +70,32 @@ public void testValueAndType() {

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245226285 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -315,6 +335,252 @@ public void testDecimalLiteral() {

[GitHub] [ignite-3] zstan commented on a diff in pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan commented on code in PR #2220: URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245273576 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java: ## @@ -315,6 +335,252 @@ public void testDecimalLiteral() {

[GitHub] [ignite-3] vldpyatkov commented on a diff in pull request #2259: IGNITE-19688 use waitAndGetLeader instead of waitLeader and getLeader

vldpyatkov commented on code in PR #2259: URL: https://github.com/apache/ignite-3/pull/2259#discussion_r1245270944 ## modules/raft/src/testFixtures/java/org/apache/ignite/raft/jraft/core/TestCluster.java: ## @@ -408,6 +408,26 @@ public void waitLeader() throws InterruptedExcepti

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10813: IGNITE-19873 GridNearTxLocal initial cleanup

sonarcloud[bot] commented on PR #10813: URL: https://github.com/apache/ignite/pull/10813#issuecomment-1611498960 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] anton-vinogradov opened a new pull request, #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

anton-vinogradov opened a new pull request, #10814: URL: https://github.com/apache/ignite/pull/10814 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10814: IGNITE-19874 GridDhtTxLocal initial cleanup

sonarcloud[bot] commented on PR #10814: URL: https://github.com/apache/ignite/pull/10814#issuecomment-1611519607 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite] anton-vinogradov opened a new pull request, #10815: IGNITE-19875 GridDhtTxLocalAdapter initial cleanup

anton-vinogradov opened a new pull request, #10815: URL: https://github.com/apache/ignite/pull/10815 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10815: IGNITE-19875 GridDhtTxLocalAdapter initial cleanup

sonarcloud[bot] commented on PR #10815: URL: https://github.com/apache/ignite/pull/10815#issuecomment-1611563570 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qua

[GitHub] [ignite-3] zstan merged pull request #2220: IGNITE-19353: Sql. Incorrect type conversion for dynamic parameters - CAST operation ignores type precision.

zstan merged PR #2220: URL: https://github.com/apache/ignite-3/pull/2220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10798: IGNITE-19675 [IEP-104] Implement WALIterator over ByteBuffer

sonarcloud[bot] commented on PR #10798: URL: https://github.com/apache/ignite/pull/10798#issuecomment-1611665269 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10797: IGNITE-19753 Move task classes to commands

sonarcloud[bot] commented on PR #10797: URL: https://github.com/apache/ignite/pull/10797#issuecomment-1611707524 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] xtern commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

xtern commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245634852 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/PrepareServiceSelfTest.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite-3] xtern commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

xtern commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1245634852 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/PrepareServiceSelfTest.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [ignite] Indupa commented on issue #10747: Does Apache Ignite 2.15.0 Runs using OpenJDK 17 version ......?

Indupa commented on issue #10747: URL: https://github.com/apache/ignite/issues/10747#issuecomment-1612375313 Hii, Can you please help me on resolving this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders

korlov42 commented on code in PR #2265: URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246181578 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java: ## @@ -67,4 +74,19 @@ public void testSimpleQuery() {

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

korlov42 commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1246198785 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestNode.java: ## @@ -81,7 +80,7 @@ public class TestNode implements LifecycleAwa

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1246212126 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -826,45 +826,69 @@ private void enlist(SourceAwareIgni

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2263: IGNITE-19843 Unify code that triggers rebalance

sanpwc commented on code in PR #2263: URL: https://github.com/apache/ignite-3/pull/2263#discussion_r1246223324 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -153,80 +149,48 @@ public

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2263: IGNITE-19843 Unify code that triggers rebalance

sanpwc commented on code in PR #2263: URL: https://github.com/apache/ignite-3/pull/2263#discussion_r1246223324 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -153,80 +149,48 @@ public

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2263: IGNITE-19843 Unify code that triggers rebalance

sanpwc commented on code in PR #2263: URL: https://github.com/apache/ignite-3/pull/2263#discussion_r1246223324 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -153,80 +149,48 @@ public

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1246227747 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -888,14 +903,6 @@ private CompletableFuture awaitFrag

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1246227747 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -888,14 +903,6 @@ private CompletableFuture awaitFrag

[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2241: IGNITE-19730 Sql. ExecutionServiceImplTest different tests failed

korlov42 commented on code in PR #2241: URL: https://github.com/apache/ignite-3/pull/2241#discussion_r1246229842 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java: ## @@ -826,45 +826,69 @@ private void enlist(SourceAwareIgni

[GitHub] [ignite] alex-plekhanov opened a new pull request, #10816: IGNITE-19811 Fix continuous queries backup ack message sending for ex…

alex-plekhanov opened a new pull request, #10816: URL: https://github.com/apache/ignite/pull/10816 …pired entries Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps ha

[GitHub] [ignite] sonarcloud[bot] commented on pull request #10816: IGNITE-19811 Fix continuous queries backup ack message sending for ex…

sonarcloud[bot] commented on PR #10816: URL: https://github.com/apache/ignite/pull/10816#issuecomment-1612583804 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Ga

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

AMashenkov commented on code in PR #2226: URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1246271834 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/PrepareServiceSelfTest.java: ## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache S

[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

sanpwc commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246240312 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -85,6 +86,8 @@ public cla

[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2265: IGNITE-19775 Add index builder to TestBuilders

AMashenkov commented on code in PR #2265: URL: https://github.com/apache/ignite-3/pull/2265#discussion_r1246362635 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/framework/TestClusterTest.java: ## @@ -67,4 +74,19 @@ public void testSimpleQuery() {

[GitHub] [ignite] zstan opened a new pull request, #10817: IGNITE-19878 Restrict possibility to create two caches with the same schemas and index names

zstan opened a new pull request, #10817: URL: https://github.com/apache/ignite/pull/10817 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The C

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2264: IGNITE-19857 Default zone replica count is not listened by rebalance trigger

rpuch commented on code in PR #2264: URL: https://github.com/apache/ignite-3/pull/2264#discussion_r1246390588 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -85,6 +86,8 @@ public clas

<    4   5   6   7   8   9   10   11   12   13   >