zstan commented on code in PR #2220:
URL: https://github.com/apache/ignite-3/pull/2220#discussion_r1245263682
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlDecimalLiteralTest.java:
##########
@@ -66,6 +70,32 @@ public void testValueAndType() {
assertEquals(expectedType, actualType, "type");
}
+ /**
+ * Type of numeric literal and type of decimal literal should match.
+ */
+ @ParameterizedTest
+ @CsvSource({
Review Comment:
if we call "1000000000000000000000000" here, test will fail, is it ok ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
