rpuch commented on code in PR #2261:
URL: https://github.com/apache/ignite-3/pull/2261#discussion_r1245012622
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -987,6 +954,49 @@ public void init(
cmgMgr.initCluster(metaStorageNodeNames, cmgNodeNames, clusterName,
clusterConfiguration);
}
+ /**
+ * Recovers components state on start by invoking configuration listeners
({@link #notifyConfigurationListeners()}
+ * and deploying watches after that.
+ */
+ private CompletableFuture<?> recoverComponentsStateOnStart(ExecutorService
startupExecutor) {
Review Comment:
The parameter could be omitted, the field seems to be accessible here
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/RevisionUpdateListener.java:
##########
@@ -20,12 +20,15 @@
import java.util.concurrent.CompletableFuture;
/**
- * The listener which receives and handles the Meta Storage revision update.
+ * The listener which receives and handles the Meta Storage revision update.
No listeners for revision {@code N+1} will be invoked until
+ * all listeners for revision {@code N} are completed.
+ * Also, this listeners is only triggered strictly after all {@link
WatchListener#onUpdate(WatchEvent)} are executed, but not necessarily
+ * completed, for the specified revision.
Review Comment:
```suggestion
* Also, this listener is only triggered strictly after all {@link
WatchListener#onUpdate(WatchEvent)} are invoked (but the returned futures
* might not still be completed completed), for the specified revision.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
