[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2226: IGNITE-17765 Sql. Introduce cache for parsed statements

[via GitHub]

korlov42 commented on code in PR #2226:
URL: https://github.com/apache/ignite-3/pull/2226#discussion_r1244811505


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -72,10 +84,13 @@ public class PrepareServiceImpl implements PrepareService, 
SchemaUpdateListener
 
     private final DdlSqlToCommandConverter ddlConverter;
 
-    private final ConcurrentMap<CacheKey, CompletableFuture<QueryPlan>> cache;
+    private final ConcurrentMap<CacheKey, CompletableFuture<QueryPlan>> 
planCache;
+    private final ConcurrentMap<CacheKey, String> normalizedQueryCache;

Review Comment:
   What is the reason to have normalizedQueryCache like mapping _CacheKey_ --> 
String ?



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/PrepareServiceImpl.java:
##########
@@ -72,10 +84,13 @@ public class PrepareServiceImpl implements PrepareService, 
SchemaUpdateListener
 
     private final DdlSqlToCommandConverter ddlConverter;
 
-    private final ConcurrentMap<CacheKey, CompletableFuture<QueryPlan>> cache;
+    private final ConcurrentMap<CacheKey, CompletableFuture<QueryPlan>> 
planCache;
+    private final ConcurrentMap<CacheKey, String> normalizedQueryCache;
 
     private final String nodeName;
 
+    private final BiFunction<SqlNode, IgnitePlanner, IgniteRel> queryOptimizer;

Review Comment:
   let's introduce interface instead of BiFunction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org