Re: [PR] IGNITE-23760 Update Apache Ignite 2.17 release notes [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11778: URL: https://github.com/apache/ignite/pull/11778#issuecomment-2562290781 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Fixed putIfAbsent() return error [ignite]

2024-12-26 Thread via GitHub
timoninmaxim closed pull request #758: Fixed putIfAbsent() return error URL: https://github.com/apache/ignite/pull/758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] IGNITE-15083 Remove "instanceof BinaryMarshaller" from tests [ignite]

2024-12-26 Thread via GitHub
nizhikov opened a new pull request, #11780: URL: https://github.com/apache/ignite/pull/11780 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### Th

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-26 Thread via GitHub
ascherbakoff commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1897405210 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -801,13 +822,23 @@ private void processOperation(

Re: [PR] Ignite-2521 Need to increase test coverage (support all configurations combinations) [ignite]

2024-12-26 Thread via GitHub
timoninmaxim commented on PR #446: URL: https://github.com/apache/ignite/pull/446#issuecomment-2562551067 Already merged at commit #953b575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Ignite-2521 Need to increase test coverage (support all configurations combinations) [ignite]

2024-12-26 Thread via GitHub
timoninmaxim closed pull request #446: Ignite-2521 Need to increase test coverage (support all configurations combinations) URL: https://github.com/apache/ignite/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] IGNITE-23598 Fix LengthPrefixCodec issue with 3 byte buffer [ignite]

2024-12-26 Thread via GitHub
tmgodinho commented on code in PR #11777: URL: https://github.com/apache/ignite/pull/11777#discussion_r1897837211 ## modules/platforms/cpp/network/src/network/length_prefix_codec.cpp: ## @@ -45,7 +45,7 @@ namespace ignite DataBuffer LengthPrefixCodec::Decode(DataBuffe

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1897953756 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -801,13 +822,23 @@ private void processOperation(Ch

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1897957160 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java: ## @@ -985,17 +1016,26 @@ private static Object unpackEx

[PR] IGNITE-24121 Use HeapLockManager with less slots in tests [ignite-3]

2024-12-26 Thread via GitHub
rpuch opened a new pull request, #4975: URL: https://github.com/apache/ignite-3/pull/4975 https://issues.apache.org/jira/browse/IGNITE-24121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-15083 Remove "instanceof BinaryMarshaller" from tests [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11780: URL: https://github.com/apache/ignite/pull/11780#issuecomment-2562384248 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24060 Fix scale down behaviour for HA zones [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov merged PR #4973: URL: https://github.com/apache/ignite-3/pull/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Fixed putIfAbsent() return error [ignite]

2024-12-26 Thread via GitHub
timoninmaxim commented on PR #758: URL: https://github.com/apache/ignite/pull/758#issuecomment-2562590488 SpringCache class is removed in #8781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] fix: Unexpected exception during cache update java.lang.ArrayIndexOu… [ignite]

2024-12-26 Thread via GitHub
timoninmaxim closed pull request #998: fix: Unexpected exception during cache update java.lang.ArrayIndexOu… URL: https://github.com/apache/ignite/pull/998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] fix: Unexpected exception during cache update java.lang.ArrayIndexOu… [ignite]

2024-12-26 Thread via GitHub
timoninmaxim commented on PR #998: URL: https://github.com/apache/ignite/pull/998#issuecomment-2562596731 Fixed in #1017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898005463 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java: ## @@ -420,27 +421,51 @@ public static TableNotFound

Re: [PR] IGNITE-23598 Fix LengthPrefixCodec issue with 3 byte buffer [ignite]

2024-12-26 Thread via GitHub
tmgodinho commented on code in PR #11777: URL: https://github.com/apache/ignite/pull/11777#discussion_r1897837211 ## modules/platforms/cpp/network/src/network/length_prefix_codec.cpp: ## @@ -45,7 +45,7 @@ namespace ignite DataBuffer LengthPrefixCodec::Decode(DataBuffe

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
Vladsz83 commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1897448779 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,441 @@ +/* + * Lice

Re: [PR] IGNITE-23760 Update Apache Ignite 2.17 release notes [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11778: URL: https://github.com/apache/ignite/pull/11778#issuecomment-2562669882 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] set default zone to HA [ignite-3]

2024-12-26 Thread via GitHub
kgusakov opened a new pull request, #4979: URL: https://github.com/apache/ignite-3/pull/4979 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: #

[PR] IGNITE-24122 Add -Xmx1g to defaultJvmArgs [ignite-3]

2024-12-26 Thread via GitHub
rpuch opened a new pull request, #4976: URL: https://github.com/apache/ignite-3/pull/4976 https://issues.apache.org/jira/browse/IGNITE-24122 Also, decrease default heap sizes for unit and integration tests to 1g and 2g, respectively -- This is an automated message from the Apache G

Re: [PR] IGNITE-15083 Remove "instanceof BinaryMarshaller" from tests [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11780: URL: https://github.com/apache/ignite/pull/11780#issuecomment-2562391474 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-23598 Fix LengthPrefixCodec issue with 3 byte buffer [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11777: URL: https://github.com/apache/ignite/pull/11777#issuecomment-2562414565 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-23748 Lock LWM when executing RO operation on data node [ignite-3]

2024-12-26 Thread via GitHub
rpuch opened a new pull request, #4974: URL: https://github.com/apache/ignite-3/pull/4974 https://issues.apache.org/jira/browse/IGNITE-23748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-15083 Remove most of BinaryMarshaller from tests [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11764: URL: https://github.com/apache/ignite/pull/11764#issuecomment-2562338159 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [PR] IGNITE-24076 Distributed properties to block new connections [ignite]

2024-12-26 Thread via GitHub
nizhikov merged PR #11766: URL: https://github.com/apache/ignite/pull/11766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-24036 Sql schema. Introduce QualifiedName class [ignite-3]

2024-12-26 Thread via GitHub
AMashenkov commented on code in PR #4971: URL: https://github.com/apache/ignite-3/pull/4971#discussion_r1897756040 ## modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java: ## @@ -0,0 +1,306 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [I] [bug]ignite connection is not a safe-thread ? [ignite]

2024-12-26 Thread via GitHub
lichaohao commented on issue #11779: URL: https://github.com/apache/ignite/issues/11779#issuecomment-2562327825 May I ask ? thank you very much . @ptupitsyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] IGNITE-23760 Update Apache Ignite 2.17 release notes [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11778: URL: https://github.com/apache/ignite/pull/11778#issuecomment-2562888683 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
Vladsz83 commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1897963065 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -58,6 +58,13 @@ public class ColocationGroup

[PR] IGNITE-24106 TC experiment [ignite-3]

2024-12-26 Thread via GitHub
alievmirza opened a new pull request, #4978: URL: https://github.com/apache/ignite-3/pull/4978 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898328373 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -58,6 +58,13 @@ public class Colocatio

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
sonarqubecloud[bot] commented on PR #11758: URL: https://github.com/apache/ignite/pull/11758#issuecomment-2563417857 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://son

Re: [I] Per-entry expiry policy [ignite]

2024-12-26 Thread via GitHub
ravaelamanov commented on issue #11775: URL: https://github.com/apache/ignite/issues/11775#issuecomment-2563420036 Well, that's the thing, I need to specify expiration duration on the cache level: ```java IgniteCache cache = ignite.cache("myCache") .withExpiryPolicy(new

[PR] Moved recovery tests to the transaction suite. [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov opened a new pull request, #4980: URL: https://github.com/apache/ignite-3/pull/4980 https://issues.apache.org/jira/browse/IGNITE-24010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] IGNITE-24124 Fix pool starvation in TableManager#beforeNodeStop() [ignite-3]

2024-12-26 Thread via GitHub
rpuch opened a new pull request, #4981: URL: https://github.com/apache/ignite-3/pull/4981 https://issues.apache.org/jira/browse/IGNITE-24124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] IGNITE-24125 [ducktests] Fix JMXClient to read MBeans with names containing spaces [ignite]

2024-12-26 Thread via GitHub
skorotkov opened a new pull request, #11781: URL: https://github.com/apache/ignite/pull/11781 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

Re: [PR] IGNITE-24121 Use HeapLockManager with less slots in tests [ignite-3]

2024-12-26 Thread via GitHub
Phillippko commented on code in PR #4975: URL: https://github.com/apache/ignite-3/pull/4975#discussion_r1898197179 ## modules/transactions/src/test/java/org/apache/ignite/internal/tx/impl/OrphanDetectorTest.java: ## @@ -107,7 +107,7 @@ public class OrphanDetectorTest extends Ba

Re: [PR] IGNITE-23760 Update Apache Ignite 2.17 release notes [ignite]

2024-12-26 Thread via GitHub
NSAmelchev merged PR #11778: URL: https://github.com/apache/ignite/pull/11778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-24122 Add -Xmx1g to defaultJvmArgs [ignite-3]

2024-12-26 Thread via GitHub
rpuch merged PR #4976: URL: https://github.com/apache/ignite-3/pull/4976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24124 Fix pool starvation in TableManager#beforeNodeStop() [ignite-3]

2024-12-26 Thread via GitHub
rpuch merged PR #4981: URL: https://github.com/apache/ignite-3/pull/4981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898317854 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -216,7 +243,16 @@ public ColocationGro

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898327211 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,441 @@ +/* +

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898327746 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,441 @@ +/* +

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898327882 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -194,11 +218,14 @@ public ColocationGr

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898328099 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/ColocationGroup.java: ## @@ -66,6 +73,11 @@ public static Colocati

Re: [PR] IGNITE-23305 Get rid of client HybridTimestampTracker [ignite-3]

2024-12-26 Thread via GitHub
vldpyatkov commented on code in PR #4929: URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1898239887 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/HybridTimestampTrackerImpl.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-26 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898302027 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -241,30 +215,46 @@ private void onWriteBusy(Iterator> it

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-26 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898305868 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -285,8 +289,10 @@ private class LogEntryAndClosureHandler implements EventHandler

Re: [I] Per-entry expiry policy [ignite]

2024-12-26 Thread via GitHub
ptupitsyn commented on issue #11775: URL: https://github.com/apache/ignite/issues/11775#issuecomment-2563384076 You can do that in Ignite > You can also change or set Expiry Policy for individual cache operations. This policy is used for each operation invoked on the returned cache in

Re: [I] [bug]ignite connection is not a safe-thread ? [ignite]

2024-12-26 Thread via GitHub
ptupitsyn commented on issue #11779: URL: https://github.com/apache/ignite/issues/11779#issuecomment-2563388464 @lichaohao which API are we talking about? Please share a code example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] IGNITE-23975 SQL Calcite: Add group partitions reservation [ignite]

2024-12-26 Thread via GitHub
alex-plekhanov commented on code in PR #11758: URL: https://github.com/apache/ignite/pull/11758#discussion_r1898314111 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/topology/PartitionReservationManager.java: ## @@ -0,0 +1,441 @@ +/* +

Re: [PR] IGNITE-24036 Sql schema. Introduce QualifiedName class [ignite-3]

2024-12-26 Thread via GitHub
zstan commented on code in PR #4971: URL: https://github.com/apache/ignite-3/pull/4971#discussion_r1898270158 ## modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java: ## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] IGNITE-24121 Use HeapLockManager with less slots in tests [ignite-3]

2024-12-26 Thread via GitHub
rpuch merged PR #4975: URL: https://github.com/apache/ignite-3/pull/4975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24121 Use HeapLockManager with less slots in tests [ignite-3]

2024-12-26 Thread via GitHub
rpuch commented on code in PR #4975: URL: https://github.com/apache/ignite-3/pull/4975#discussion_r1898275897 ## modules/transactions/src/test/java/org/apache/ignite/internal/tx/impl/OrphanDetectorTest.java: ## @@ -107,7 +107,7 @@ public class OrphanDetectorTest extends BaseIgn

[PR] IGNITE-24126 [ducktests] Fix flacky jdbc_thin_test [ignite]

2024-12-26 Thread via GitHub
skorotkov opened a new pull request, #11782: URL: https://github.com/apache/ignite/pull/11782 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### T

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-26 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898296919 ## modules/raft-api/src/main/java/org/apache/ignite/internal/raft/Command.java: ## @@ -17,10 +17,27 @@ package org.apache.ignite.internal.raft; +import org.apache.

Re: [PR] IGNITE-23304 [ignite-3]

2024-12-26 Thread via GitHub
sanpwc commented on code in PR #4821: URL: https://github.com/apache/ignite-3/pull/4821#discussion_r1898297760 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -447,6 +447,10 @@ public boolean startRaftNode( // Th