vldpyatkov commented on code in PR #4929:
URL: https://github.com/apache/ignite-3/pull/4929#discussion_r1897957160
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -985,17 +1016,26 @@ private static Object
unpackExtensionValue(HandshakeExtension handshakeExtension
return null;
}
+ /**
+ * Gets an observation timestamp for the operation being processed or
{@link HybridTimestamp#MIN_VALUE} if the timestamp was not defined
+ * by the operation.
+ * The method returns a current timestamp for the handshake operation.
+ *
+ * @param out Output message packer.
+ * @return A long representation of the observation timestamp.
+ */
private long observableTimestamp(@Nullable ClientMessagePacker out) {
- // Certain operations can override the timestamp and provide it in the
meta object.
- if (out != null) {
- Object meta = out.meta();
+ if (out == null) {
+ return clockService.currentLong();
Review Comment:
But we have tests where we consider it.
I mean the test where we make a schema (create table, zones) and then start
a client, which has to execute a query over this schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
