[PR] IGNITE-23623 Fix GridCacheAbstractSelfTest [ignite]

2024-11-19 Thread via GitHub
chesnokoff opened a new pull request, #11666: URL: https://github.com/apache/ignite/pull/11666 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

Re: [PR] IGNITE-23701 Add output of execution duration LogSyncer to message "Checkpoint finished" [ignite-3]

2024-11-19 Thread via GitHub
rpuch commented on code in PR #4744: URL: https://github.com/apache/ignite-3/pull/4744#discussion_r1848022879 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMetricsTracker.java: ## @@ -66,6 +66,8 @@ public class Checkp

Re: [PR] IGNITE-23110 Disallow IgniteCache#clear() within transaction [ignite]

2024-11-19 Thread via GitHub
timoninmaxim commented on code in PR #11559: URL: https://github.com/apache/ignite/pull/11559#discussion_r1847995288 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java: ## @@ -1059,16 +1064,25 @@ public List> splitClearLocally(boolea

Re: [PR] IGNITE-23403 Remove Unused error codes [ignite-3]

2024-11-19 Thread via GitHub
tkalkirill merged PR #4742: URL: https://github.com/apache/ignite-3/pull/4742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
vldpyatkov commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848122814 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -107,33 +95,34 @@ private void notifyUpdateListeners(long newTs) { }

Re: [PR] IGNITE-17443 Implement OpenTelemetry metric exporter. [ignite-3]

2024-11-19 Thread via GitHub
nva merged PR #4531: URL: https://github.com/apache/ignite-3/pull/4531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.

Re: [PR] IGNITE-23110 Disallow IgniteCache#clear() within transaction [ignite]

2024-11-19 Thread via GitHub
J-Bakuli commented on code in PR #11559: URL: https://github.com/apache/ignite/pull/11559#discussion_r1848154625 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java: ## @@ -1059,16 +1064,25 @@ public List> splitClearLocally(boolean sr

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847879258 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23623 Fix GridCacheAbstractSelfTest [ignite]

2024-11-19 Thread via GitHub
chesnokoff closed pull request #11666: IGNITE-23623 Fix GridCacheAbstractSelfTest URL: https://github.com/apache/ignite/pull/11666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] IGNITE-23623 Fix GridCacheAbstractSelfTest [ignite]

2024-11-19 Thread via GitHub
chesnokoff closed pull request #11666: IGNITE-23623 Fix GridCacheAbstractSelfTest URL: https://github.com/apache/ignite/pull/11666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] IGNITE-23701 Add output of execution duration LogSyncer to message "Checkpoint finished" [ignite-3]

2024-11-19 Thread via GitHub
tkalkirill merged PR #4744: URL: https://github.com/apache/ignite-3/pull/4744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23587 Make PlacementDriver able to choose lease candidate from pendings [ignite-3]

2024-11-19 Thread via GitHub
sanpwc merged PR #4707: URL: https://github.com/apache/ignite-3/pull/4707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23623 Fix GridCacheAbstractMetricsSelfTest [ignite]

2024-11-19 Thread via GitHub
chesnokoff closed pull request #11658: IGNITE-23623 Fix GridCacheAbstractMetricsSelfTest URL: https://github.com/apache/ignite/pull/11658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847962944 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java: ## @@ -272,19 +302,28 @@ private static CompletableFuture

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847977214 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java: ## @@ -272,19 +302,28 @@ private static CompletableFuture

[PR] IGNITE-23701 Add output of execution duration LogSyncer to message "Checkpoint finished" [ignite-3]

2024-11-19 Thread via GitHub
tkalkirill opened a new pull request, #4744: URL: https://github.com/apache/ignite-3/pull/4744 https://issues.apache.org/jira/browse/IGNITE-23701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
Cyrill commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847932057 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
Cyrill commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847929881 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847962944 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java: ## @@ -272,19 +302,28 @@ private static CompletableFuture

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
Cyrill commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847928444 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/AssignmentUtil.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-23674: Sql. Expose underlying schema used by RowFactory [ignite-3]

2024-11-19 Thread via GitHub
lowka commented on code in PR #4724: URL: https://github.com/apache/ignite-3/pull/4724#discussion_r1848014629 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/SqlRowHandler.java: ## @@ -199,7 +205,7 @@ public abstract static class RowWrapper {

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
Cyrill commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847932057 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23700 Fix NPE in AbstractTopologyAwareGroupServiceTest [ignite-3]

2024-11-19 Thread via GitHub
sanpwc merged PR #4743: URL: https://github.com/apache/ignite-3/pull/4743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847942303 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847942774 ## modules/runner/src/testFixtures/java/org/apache/ignite/internal/Cluster.java: ## @@ -357,6 +357,13 @@ public Ignite node(int index) { return Objects.require

Re: [PR] IGNITE-23674: Sql. Expose underlying schema used by RowFactory [ignite-3]

2024-11-19 Thread via GitHub
AMashenkov commented on code in PR #4724: URL: https://github.com/apache/ignite-3/pull/4724#discussion_r1847942612 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/SqlRowHandler.java: ## @@ -376,7 +383,8 @@ int columnsCount() { }

Re: [PR] IGNITE-23559 resetPartitions improvements: two phase reset [ignite-3]

2024-11-19 Thread via GitHub
sanpwc commented on code in PR #4688: URL: https://github.com/apache/ignite-3/pull/4688#discussion_r1847954920 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/GroupUpdateRequest.java: ## @@ -272,19 +302,28 @@ private static CompletableFuture

Re: [PR] IGNITE-23650 SQL Calcite: Refactor IndexScan/TableScan classes hierarchy [ignite]

2024-11-19 Thread via GitHub
alex-plekhanov commented on code in PR #11650: URL: https://github.com/apache/ignite/pull/11650#discussion_r1848737202 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/AbstractCacheScan.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848621137 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1107,7 +1116,7 @@ public CompletableFuture upse

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848348138 ## modules/core/src/test/java/org/apache/ignite/internal/util/PendingComparableValuesTrackerTest.java: ## @@ -256,7 +257,8 @@ void testClose(PendingComparableValu

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
rpuch commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848078340 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -38,45 +37,34 @@ public class HybridClockImpl implements HybridClock { /**

[PR] IGNITE-23708 testAutomaticRebalanceIfMajorityIsLost is flacky [ignite-3]

2024-11-19 Thread via GitHub
JAkutenshi opened a new pull request, #4747: URL: https://github.com/apache/ignite-3/pull/4747 JIRA Ticket: [IGNITE-23708](https://issues.apache.org/jira/browse/IGNITE-23708) ## The goal The main goal of the PR is to fix `testAutomaticRebalanceIfMajorityIsLost`: 1. Reset

Re: [PR] IGNITE-23110 Disallow IgniteCache#clear() within transaction [ignite]

2024-11-19 Thread via GitHub
zstan commented on PR #11559: URL: https://github.com/apache/ignite/pull/11559#issuecomment-2485691253 plz remove commented code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[PR] Bump io.opentelemetry:opentelemetry-exporter-otlp from 1.42.1 to 1.44.1 [ignite-3]

2024-11-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4753: URL: https://github.com/apache/ignite-3/pull/4753 Bumps [io.opentelemetry:opentelemetry-exporter-otlp](https://github.com/open-telemetry/opentelemetry-java) from 1.42.1 to 1.44.1. Release notes Sourced from https://github.com/open-

Re: [PR] IGNITE-23623 Fix GridCacheAbstractMetricsSelfTest [ignite]

2024-11-19 Thread via GitHub
timoninmaxim commented on code in PR #11658: URL: https://github.com/apache/ignite/pull/11658#discussion_r1846210211 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheAbstractSelfTest.java: ## @@ -150,8 +150,8 @@ else if (isMultiJvm() && !(storeS

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848618079 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -1107,7 +1116,7 @@ public CompletableFuture upse

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848622624 ## modules/table/src/testFixtures/java/org/apache/ignite/distributed/ItTxTestCluster.java: ## @@ -549,6 +546,14 @@ public void prepareCluster() throws Exception {

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848624661 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -107,33 +95,34 @@ private void notifyUpdateListeners(long newTs) { }

Re: [PR] IGNITE-23658 : Support bitwise operations: BITAND, BITOR, BITXOR. [ignite]

2024-11-19 Thread via GitHub
alex-plekhanov commented on code in PR #11655: URL: https://github.com/apache/ignite/pull/11655#discussion_r1848472744 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/FunctionsTest.java: ## @@ -58,6 +60,165 @@ public void testQuer

[PR] Bump Microsoft.NET.Test.Sdk from 17.11.1 to 17.12.0 in /modules/platforms/dotnet [ignite-3]

2024-11-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4752: URL: https://github.com/apache/ignite-3/pull/4752 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.11.1 to 17.12.0. Release notes Sourced from https://github.com/microsoft/vstest/releases";>Microsoft.NET.T

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848455816 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -642,11 +643,11 @@ private Completable

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848348138 ## modules/core/src/test/java/org/apache/ignite/internal/util/PendingComparableValuesTrackerTest.java: ## @@ -256,7 +257,8 @@ void testClose(PendingComparableValu

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
vldpyatkov commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848681274 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/message/ReplicaMessageGroup.java: ## @@ -49,6 +49,9 @@ public interface ReplicaMessageGrou

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848375903 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/benchmark/UpsertKvBenchmark.java: ## @@ -66,6 +66,14 @@ public class UpsertKvBenchmark exten

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848455816 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -642,11 +643,11 @@ private Completable

[PR] IGNITE-23714 Fix problem json media type [ignite-3]

2024-11-19 Thread via GitHub
Pochatkin opened a new pull request, #4756: URL: https://github.com/apache/ignite-3/pull/4756 https://issues.apache.org/jira/browse/IGNITE-23714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] IGNITE-23650 SQL Calcite: Refactor IndexScan/TableScan classes hierarchy [ignite]

2024-11-19 Thread via GitHub
alex-plekhanov commented on code in PR #11650: URL: https://github.com/apache/ignite/pull/11650#discussion_r1848733390 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/AbstractCacheScan.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
rpuch commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1849655831 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -86,8 +74,8 @@ public long nowLong() { } @Override -public long

[PR] IGNITE-23704: Incorrect equal implementation in TemporalNativeType and VarlenNativeType [ignite-3]

2024-11-19 Thread via GitHub
lowka opened a new pull request, #4748: URL: https://github.com/apache/ignite-3/pull/4748 Fixes `equals` method of `TemporalNativeType` and `VarlenNativeType `. --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better

[PR] Bump docfx from 2.78.0 to 2.78.1 in /modules/platforms/dotnet [ignite-3]

2024-11-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4751: URL: https://github.com/apache/ignite-3/pull/4751 Bumps [docfx](https://github.com/dotnet/docfx) from 2.78.0 to 2.78.1. Release notes Sourced from https://github.com/dotnet/docfx/releases";>docfx's releases. 2.78.1 What

[PR] IGNITE-23690 Fix ItTableRaftSnapshotsTest.txSemanticsIsMaintained. [ignite-3]

2024-11-19 Thread via GitHub
sanpwc opened a new pull request, #4745: URL: https://github.com/apache/ignite-3/pull/4745 https://issues.apache.org/jira/browse/IGNITE-23690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848348138 ## modules/core/src/test/java/org/apache/ignite/internal/util/PendingComparableValuesTrackerTest.java: ## @@ -256,7 +257,8 @@ void testClose(PendingComparableValu

[I] REST API: cacheName is not an optional parameter [ignite]

2024-11-19 Thread via GitHub
jfuentesa opened a new issue, #11670: URL: https://github.com/apache/ignite/issues/11670 Hello, I have been reviewing the [Apache Ignite REST API documentation](https://ignite.apache.org/docs/latest/restapi) and noticed an inconsistency. The cacheName parameter is optional for certai

Re: [PR] IGNITE-23679 [ducktests] Use dependencies from the ignite instance under test in test runtime [ignite]

2024-11-19 Thread via GitHub
ivandasch merged PR #11664: URL: https://github.com/apache/ignite/pull/11664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23624 : Calcite. Support aggregate functions BIT_AND, BIT_OR, BIT_XOR. [ignite]

2024-11-19 Thread via GitHub
alex-plekhanov commented on code in PR #11649: URL: https://github.com/apache/ignite/pull/11649#discussion_r1848632505 ## modules/calcite/src/test/sql/aggregate/aggregates/test_bit_and.test: ## @@ -5,22 +5,18 @@ # test on scalar values query II -SELECT BIT_AND(3), BIT_AND(NU

Re: [PR] IGNITE-23674: Sql. Expose underlying schema used by RowFactory [ignite-3]

2024-11-19 Thread via GitHub
lowka commented on code in PR #4724: URL: https://github.com/apache/ignite-3/pull/4724#discussion_r1848816554 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/SqlRowHandler.java: ## @@ -199,7 +205,7 @@ public abstract static class RowWrapper {

Re: [PR] IGNITE-23623 Fix GridCacheAbstractMetricsSelfTest [ignite]

2024-11-19 Thread via GitHub
chesnokoff closed pull request #11658: IGNITE-23623 Fix GridCacheAbstractMetricsSelfTest URL: https://github.com/apache/ignite/pull/11658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] IGNITE-23706 Sql. Fix flaky testCursorIsClosedAfterAllDataReadWithNodeFailure [ignite-3]

2024-11-19 Thread via GitHub
zstan opened a new pull request, #4750: URL: https://github.com/apache/ignite-3/pull/4750 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-23650 SQL Calcite: Refactor IndexScan/TableScan classes hierarchy [ignite]

2024-11-19 Thread via GitHub
alex-plekhanov commented on code in PR #11650: URL: https://github.com/apache/ignite/pull/11650#discussion_r1848737902 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/TreeIndexIterable.java: ## @@ -154,9 +114,7 @@ private void advance()

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848367854 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -38,45 +37,34 @@ public class HybridClockImpl implements HybridClock {

[PR] IGNITE-23713: Sql. Preserve scale of result type in SUM0 accumulator for DECIMAL type [ignite-3]

2024-11-19 Thread via GitHub
lowka opened a new pull request, #4754: URL: https://github.com/apache/ignite-3/pull/4754 Fixes return type for `SUM0` accumulator of DECIMAL type https://issues.apache.org/jira/browse/IGNITE-23173 Thank you for submitting the pull request. To streamline the r

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848367080 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -107,33 +95,34 @@ private void notifyUpdateListeners(long newTs) { }

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848368784 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -107,33 +95,34 @@ private void notifyUpdateListeners(long newTs) { }

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848369157 ## modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java: ## @@ -118,18 +119,20 @@ public void update(T newValue, @Nullab

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848371040 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ApplyResult.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848359061 ## modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java: ## @@ -2243,10 +2243,6 @@ public Message handleAppendEntriesRequest(final AppendEn

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848441962 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxObservableTimePropagationTest.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848443963 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -588,7 +588,7 @@ public boolean onBeforeApply(Comma

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848459914 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java: ## @@ -633,7 +634,19 @@ private CompletableFuture tra

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848338106 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridClockImpl.java: ## @@ -86,8 +74,8 @@ public long nowLong() { } @Override -publi

Re: [PR] IGNITE-23303 Improve transaction performance. [ignite-3]

2024-11-19 Thread via GitHub
ascherbakoff commented on code in PR #4700: URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848455816 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -642,11 +643,11 @@ private Completable