rpuch commented on code in PR #4744:
URL: https://github.com/apache/ignite-3/pull/4744#discussion_r1848022879
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMetricsTracker.java:
##########
@@ -66,6 +66,8 @@ public class CheckpointMetricsTracker {
private long fsyncStartNanos;
+ private long syncWalStartNanos;
Review Comment:
It seems that 'WAL sync' is more natural in English (it's 'sync of the WAL')
than 'sync WAL' (where 'sync' must be a verb, but then 'sync WAL start' already
looks weird, while 'wal sync start' seems to be ok)
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointMetricsTracker.java:
##########
@@ -198,6 +200,15 @@ public void onSplitAndSortCheckpointPagesEnd() {
splitAndSortPagesEndNanos = System.nanoTime();
}
+ /**
+ * Callback on start sync write-ahead-log.
Review Comment:
```suggestion
* Callback on sync write-ahead-log start.
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -898,4 +894,16 @@ CompletableFuture<Void>
prepareToDestroyPartition(GroupPartitionId groupPartitio
return processedPartitionFuture == null ? nullCompletedFuture() :
processedPartitionFuture;
}
+
+ private void syncWal(CheckpointMetricsTracker tracker) throws
IgniteInternalCheckedException {
+ try {
+ tracker.onSyncWalStart();
Review Comment:
In Ignite 2, the log was a WAL and this term was used in the whole codebase.
In Ignite 3, we usually talk about Raft log (or simply log) and not a WAL.
Maybe it will be more consistent to use 'log' term instead of 'WAL' in this
class as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
