ascherbakoff commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1848618079
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1107,7 +1116,7 @@ public CompletableFuture<Void> upsert(BinaryRowEx row,
@Nullable InternalTransac
.transactionId(txo.id())
.enlistmentConsistencyToken(enlistmentConsistencyToken)
.requestType(RW_UPSERT)
- .timestamp(clockService.now())
+ .timestamp(txo.startTimestamp()) // TODO replace
everythere
Review Comment:
We can use startTs here because it doesn't affect transaction ordering
guaranties. Proper order is provided by locking, and the response will always
have timestamp greater or equal to latest committed dependent transaction. See
IEP-91 for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
