JAkutenshi opened a new pull request, #4747:
URL: https://github.com/apache/ignite-3/pull/4747

   JIRA Ticket: 
[IGNITE-23708](https://issues.apache.org/jira/browse/IGNITE-23708)
   
   ## The goal
   
   The main goal of the PR is to fix `testAutomaticRebalanceIfMajorityIsLost`:
   
   1. Reset rebalance may be slower a little than expected 2s timeout on 
`assertRealAssignments(node0, partId, 1)` especially after 
[IGNITE-22036](https://issues.apache.org/jira/browse/IGNITE-22036) changes.
   2. There is unnecessary planned rebalance with the same planned assignments 
as pending force reset assignments set equals to `[1]`. This leads also to a 
flacky non-null result on `assertNull(getPendingAssignments(node0, partId))` 
check.
   
   ## The reason
   
   Tests shouldn't be flacky and flawed implementation should be fixed.
   
   ## The solution
   
   1. `assertRealAssignments`'s timeout is increased up to 5s.
   2. If during `GroupUpdateRequest#partitionUpdate` if there are alive nodes 
we have equal `part` and `stable` assignments we shouldn't schedule the 
redundant rebalance and then should put just `null` then.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to