Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825744093 ## modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java: ## @@ -183,6 +185,29 @@ public class CdcMain implements Runnable { private static fina

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743670 ## modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java: ## @@ -204,6 +229,12 @@ public class CdcMain implements Runnable { /** Time of last se

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743887 ## docs/_docs/persistence/change-data-capture.adoc: ## @@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be | Binary

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825746883 ## modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java: ## @@ -616,6 +652,18 @@ private void consumeSegmentActively(IgniteWalIteratorFactory.Itera

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825749155 ## modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java: ## @@ -183,6 +185,29 @@ public class CdcMain implements Runnable { private static fina

Re: [PR] IGNITE-22733 Support transactions in Scan query [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11580: URL: https://github.com/apache/ignite/pull/11580#issuecomment-2451877505 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] Bump com.github.spotbugs from 6.0.25 to 6.0.26 [ignite-3]

2024-11-01 Thread via GitHub
dependabot[bot] opened a new pull request, #4669: URL: https://github.com/apache/ignite-3/pull/4669 Bumps com.github.spotbugs from 6.0.25 to 6.0.26. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spo

Re: [PR] IGNITE-22573 Fix warnings of IpFinderCleaner [ignite]

2024-11-01 Thread via GitHub
alex-plekhanov commented on code in PR #11637: URL: https://github.com/apache/ignite/pull/11637#discussion_r1825965412 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -937,8 +937,11 @@ private boolean pingNode(TcpDiscoveryNode node) {

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825744264 ## modules/core/src/main/java/org/apache/ignite/internal/cdc/CdcMain.java: ## @@ -204,6 +229,12 @@ public class CdcMain implements Runnable { /** Time of last se

Re: [PR] Ignite 18312 tc debug [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11344: URL: https://github.com/apache/ignite/pull/11344#issuecomment-2451804452 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23168 Event consumption time metric in CDC consumer [ignite]

2024-11-01 Thread via GitHub
maksaska commented on code in PR #11612: URL: https://github.com/apache/ignite/pull/11612#discussion_r1825743477 ## docs/_docs/persistence/change-data-capture.adoc: ## @@ -125,6 +125,8 @@ The following metrics are provided by the application (additional metrics can be | Binary

Re: [PR] IGNITE-23408 : Calcite. 'Typeof' should fail in case of incorrect parameter. [ignite]

2024-11-01 Thread via GitHub
asfgit closed pull request #11636: IGNITE-23408 : Calcite. 'Typeof' should fail in case of incorrect parameter. URL: https://github.com/apache/ignite/pull/11636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] IGNITE-23557 : Calcite. Assertion in COUNT(DISTINCT) accumulator. [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11630: URL: https://github.com/apache/ignite/pull/11630#issuecomment-2451974626 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-22573 Fix warnings of IpFinderCleaner [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11637: URL: https://github.com/apache/ignite/pull/11637#issuecomment-2451978186 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23584 : Snapshot. Fix logic of the quick snapshot handler. [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11632: URL: https://github.com/apache/ignite/pull/11632#issuecomment-2451475532 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23584 : Snapshot. Fix logic of the quick snapshot handler. [ignite]

2024-11-01 Thread via GitHub
NSAmelchev merged PR #11632: URL: https://github.com/apache/ignite/pull/11632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] Ignite 18312 tc debug [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11344: URL: https://github.com/apache/ignite/pull/11344#issuecomment-2451532916 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-01 Thread via GitHub
ivanzlenko opened a new pull request, #4668: URL: https://github.com/apache/ignite-3/pull/4668 https://issues.apache.org/jira/browse/IGNITE-23582 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-01 Thread via GitHub
ibessonov commented on code in PR #4668: URL: https://github.com/apache/ignite-3/pull/4668#discussion_r1825599275 ## packaging/common/linux/bootstrap-functions.sh: ## @@ -34,9 +34,15 @@ export LOGGING_JAVA_OPTS=" export CLASSPATH="-classpath @INSTALL_DIR@/lib/@APP_JAR@:@INSTA

Re: [PR] IGNITE-23472 Fix JavaLogger [ignite]

2024-11-01 Thread via GitHub
chesnokoff commented on code in PR #11615: URL: https://github.com/apache/ignite/pull/11615#discussion_r1825648205 ## modules/core/src/main/java/org/apache/ignite/logger/java/JavaLogger.java: ## @@ -134,7 +138,7 @@ public class JavaLogger implements IgniteLoggerEx { * Crea

Re: [PR] IGNITE-23054 Improve cluster status REST endpoint [ignite-3]

2024-11-01 Thread via GitHub
valepakh commented on code in PR #4614: URL: https://github.com/apache/ignite-3/pull/4614#discussion_r1825660349 ## modules/cli/src/main/java/org/apache/ignite/internal/cli/call/cluster/status/ClusterStatusCall.java: ## @@ -30,13 +30,20 @@ import org.apache.ignite.rest.client.a

Re: [PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-01 Thread via GitHub
ivanzlenko commented on code in PR #4668: URL: https://github.com/apache/ignite-3/pull/4668#discussion_r1825615863 ## packaging/common/linux/bootstrap-functions.sh: ## @@ -34,9 +34,15 @@ export LOGGING_JAVA_OPTS=" export CLASSPATH="-classpath @INSTALL_DIR@/lib/@APP_JAR@:@INST

Re: [PR] IGNITE-23582 Fix missing memory and GC settings [ignite-3]

2024-11-01 Thread via GitHub
valepakh commented on code in PR #4668: URL: https://github.com/apache/ignite-3/pull/4668#discussion_r1825613876 ## packaging/common/windows/bootstrap-functions.bat: ## @@ -26,6 +26,16 @@ set LOGGING_JAVA_OPTS=-Djava.util.logging.config.file="@CONF_DIR@\ignite.java.ut set CL

Re: [PR] IGNITE-23557 : Calcite. Assertion in COUNT(DISTINCT) accumulator. [ignite]

2024-11-01 Thread via GitHub
sonarcloud[bot] commented on PR #11630: URL: https://github.com/apache/ignite/pull/11630#issuecomment-2451634027 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23557 : Calcite. Assertion in COUNT(DISTINCT) accumulator. [ignite]

2024-11-01 Thread via GitHub
alex-plekhanov commented on code in PR #11630: URL: https://github.com/apache/ignite/pull/11630#discussion_r1825493925 ## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/agg/Accumulators.java: ## @@ -1333,19 +1336,28 @@ private static c

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-01 Thread via GitHub
zstan commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1825730716 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProvider.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22969 Sql. Replanning query on unstable topology [ignite-3]

2024-11-01 Thread via GitHub
zstan commented on code in PR #4629: URL: https://github.com/apache/ignite-3/pull/4629#discussion_r1825731242 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/ExecutionDistributionProviderImpl.java: ## @@ -205,4 +230,46 @@ private CompletableFuture> all

Re: [PR] IGNITE-23585 Fix flaky DeploymentUnitAcquiredWaiterTest [ignite-3]

2024-11-01 Thread via GitHub
Pochatkin merged PR #4665: URL: https://github.com/apache/ignite-3/pull/4665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23054 Improve cluster status REST endpoint [ignite-3]

2024-11-01 Thread via GitHub
rpuch commented on code in PR #4614: URL: https://github.com/apache/ignite-3/pull/4614#discussion_r1825728926 ## modules/cli/src/main/java/org/apache/ignite/internal/cli/decorators/ClusterStatusDecorator.java: ## @@ -45,4 +46,17 @@ public TerminalOutput decorate(ClusterStatus da