valepakh commented on code in PR #4668: URL: https://github.com/apache/ignite-3/pull/4668#discussion_r1825613876
########## packaging/common/windows/bootstrap-functions.bat: ########## @@ -26,6 +26,16 @@ set LOGGING_JAVA_OPTS=-Djava.util.logging.config.file="@CONF_DIR@\ignite.java.ut set CLASSPATH=-classpath "@INSTALL_DIR@\lib\*" @MAIN_CLASS@ -set JAVA_CMD_WITH_ARGS="%JAVA_EXE%" %COMMON_JAVA_OPTS% %LOGGING_JAVA_OPTS% %IGNITE3_EXTRA_JVM_ARGS% %CLASSPATH% +set JAVA_MEMORY_OPTIONS="-Xmx%JVM_MAX_MEM% -Xms%JVM_MIN_MEM%" Review Comment: ```suggestion set JAVA_MEMORY_OPTIONS=-Xmx%JVM_MAX_MEM% -Xms%JVM_MIN_MEM% ``` ########## packaging/common/windows/bootstrap-functions.bat: ########## @@ -26,6 +26,16 @@ set LOGGING_JAVA_OPTS=-Djava.util.logging.config.file="@CONF_DIR@\ignite.java.ut set CLASSPATH=-classpath "@INSTALL_DIR@\lib\*" @MAIN_CLASS@ -set JAVA_CMD_WITH_ARGS="%JAVA_EXE%" %COMMON_JAVA_OPTS% %LOGGING_JAVA_OPTS% %IGNITE3_EXTRA_JVM_ARGS% %CLASSPATH% +set JAVA_MEMORY_OPTIONS="-Xmx%JVM_MAX_MEM% -Xms%JVM_MIN_MEM%" + +set JAVA_GC_OPTIONS="-XX:+Use%JVM_GC% -XX:G1HeapRegionSize=%JVM_G1HeapRegionSize%" Review Comment: ```suggestion set JAVA_GC_OPTIONS=-XX:+Use%JVM_GC% -XX:G1HeapRegionSize=%JVM_G1HeapRegionSize% ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
